Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from k8s.gcr.io to registry.k8s.io #357

Merged
merged 1 commit into from Jun 3, 2022

Conversation

yselkowitz
Copy link
Contributor

@yselkowitz yselkowitz commented Jun 2, 2022

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This updates the image registry in accordance with:

https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-(registry.k8s.io)
kubernetes/enhancements#3079
kubernetes/kubernetes#109938

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Move image references from k8s.gcr.io to registry.k8s.io

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 2, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2022
@yselkowitz
Copy link
Contributor Author

/cc @dims

@k8s-ci-robot
Copy link
Contributor

@yselkowitz: GitHub didn't allow me to request PR reviews from the following users: dims.

Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @dims

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yselkowitz added a commit to yselkowitz/kubernetes that referenced this pull request Jun 2, 2022
Changes includes results of the following command:

test/e2e/testing-manifests/storage-csi$ ./update-hostpath.sh v1.8.0

This also includes backports from the following post-release commits:
kubernetes-csi/csi-driver-host-path#355
kubernetes-csi/csi-driver-host-path#357

Also includes a manual update of the busybox image to match the tag used
elsewhere in kubernetes e2e.
@dims
Copy link
Contributor

dims commented Jun 3, 2022

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@dims: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz
Copy link
Contributor Author

/cc @jsafrane

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
release-tools/prow.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2022
@pohly
Copy link
Contributor

pohly commented Jun 3, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

@yselkowitz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21 bfdb3e0 link false /test pull-kubernetes-csi-csi-driver-host-path-1-21-test-on-kubernetes-1-21

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pohly
Copy link
Contributor

pohly commented Jun 3, 2022

/retest

@pohly
Copy link
Contributor

pohly commented Jun 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 15e64f7 into kubernetes-csi:master Jun 3, 2022
@yselkowitz yselkowitz deleted the registry-k8s-io branch June 7, 2022 05:16
@xing-yang xing-yang added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jul 10, 2022
muyangren2 pushed a commit to muyangren2/kubernetes that referenced this pull request Jul 14, 2022
Changes includes results of the following command:

test/e2e/testing-manifests/storage-csi$ ./update-hostpath.sh v1.8.0

This also includes backports from the following post-release commits:
kubernetes-csi/csi-driver-host-path#355
kubernetes-csi/csi-driver-host-path#357

Also includes a manual update of the busybox image to match the tag used
elsewhere in kubernetes e2e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants