GetVolumeGroupSnapshot should check SnapshotIDs not SourceVolumeIDs

[nixpanic]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Due to this bug in GetVolumeGroupSnapshot, creating pre-provisioned
VolumeGroupSnapshots was not working. Pre-provisioned
VolumeGroupSnapshots refer to a list of SnapshotIDs that are part of the
VolumeGroupSnapshot, the SourceVolumeIDs are not used in that case.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Tested with kubernetes-csi/external-snapshotter#837

Does this PR introduce a user-facing change?:

Fix an issue with GetVolumeGroupSnapshot where SourceVolumeIDs were compared with SnapshotIDs.

[nixpanic]

Tested manually with YAML like:

---
apiVersion: groupsnapshot.storage.k8s.io/v1alpha1
kind: VolumeGroupSnapshotContent
metadata:
  name: manual-vgs-content
spec:
  deletionPolicy: Retain
  driver: hostpath.csi.k8s.io
  volumeGroupSnapshotRef:
    apiVersion: groupsnapshot.storage.k8s.io/v1alpha1
    kind: VolumeGroupSnapshot
    name: manual-vgs
    namespace: default
  volumeGroupSnapshotClassName: csi-hostpath-vgsc
  source:
    groupSnapshotHandles:
      volumeGroupSnapshotHandle: ef357b04-b6d2-11ee-b9e8-0a580a8003c1
      volumeSnapshotHandles:
        - ef357b49-b6d2-11ee-b9e8-0a580a8003c1

Replace volumeGroupSnapshotHandle and volumeSnapshotHandles with appropriate values.

$ kubectl get VolumeGroupSnapshotContent/manual-vgs-content -oyaml
apiVersion: groupsnapshot.storage.k8s.io/v1alpha1
kind: VolumeGroupSnapshotContent
metadata:
  creationTimestamp: "2024-01-19T18:58:42Z"
  generation: 1
  name: manual-vgs-content
  resourceVersion: "6411444"
  uid: 1da5ef37-1104-49a0-b44d-70e8eb4b65b1
spec:
  deletionPolicy: Retain
  driver: hostpath.csi.k8s.io
  source:
    groupSnapshotHandles:
      volumeGroupSnapshotHandle: ef357b04-b6d2-11ee-b9e8-0a580a8003c1
      volumeSnapshotHandles:
      - ef357b49-b6d2-11ee-b9e8-0a580a8003c1
  volumeGroupSnapshotClassName: csi-hostpath-vgsc
  volumeGroupSnapshotRef:
    apiVersion: groupsnapshot.storage.k8s.io/v1alpha1
    kind: VolumeGroupSnapshot
    name: manual-vgs
    namespace: default
status:
  creationTime: 1705672756771101019
  readyToUse: true
  volumeGroupSnapshotHandle: ef357b04-b6d2-11ee-b9e8-0a580a8003c1

[nixpanic]

/retest

[xing-yang]

@nixpanic Can you test this PR with the latest changes in external-snapshotter?

[nixpanic]

@nixpanic Can you test this PR with the latest changes in external-snapshotter?

@xing-yang I used a build of the csi-driver-hostpath that included this PR to test kubernetes-csi/external-snapshotter#837 and kubernetes-csi/external-snapshotter#995. Is there an other change that you would like to see tested?

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nixpanic, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment