-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetVolumeGroupSnapshot should check SnapshotIDs not SourceVolumeIDs #494
GetVolumeGroupSnapshot should check SnapshotIDs not SourceVolumeIDs #494
Conversation
Due to this bug in GetVolumeGroupSnapshot, creating pre-provisioned VolumeGroupSnapshots was not working. Pre-provisioned VolumeGroupSnapshots refer to a list of SnapshotIDs that are part of the VolumeGroupSnapshot, the SourceVolumeIDs are not used in that case.
Tested manually with YAML like: ---
apiVersion: groupsnapshot.storage.k8s.io/v1alpha1
kind: VolumeGroupSnapshotContent
metadata:
name: manual-vgs-content
spec:
deletionPolicy: Retain
driver: hostpath.csi.k8s.io
volumeGroupSnapshotRef:
apiVersion: groupsnapshot.storage.k8s.io/v1alpha1
kind: VolumeGroupSnapshot
name: manual-vgs
namespace: default
volumeGroupSnapshotClassName: csi-hostpath-vgsc
source:
groupSnapshotHandles:
volumeGroupSnapshotHandle: ef357b04-b6d2-11ee-b9e8-0a580a8003c1
volumeSnapshotHandles:
- ef357b49-b6d2-11ee-b9e8-0a580a8003c1 Replace
|
/retest |
@nixpanic Can you test this PR with the latest changes in external-snapshotter? |
@xing-yang I used a build of the csi-driver-hostpath that included this PR to test kubernetes-csi/external-snapshotter#837 and kubernetes-csi/external-snapshotter#995. Is there an other change that you would like to see tested? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nixpanic, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Due to this bug in GetVolumeGroupSnapshot, creating pre-provisioned
VolumeGroupSnapshots was not working. Pre-provisioned
VolumeGroupSnapshots refer to a list of SnapshotIDs that are part of the
VolumeGroupSnapshot, the SourceVolumeIDs are not used in that case.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Tested with kubernetes-csi/external-snapshotter#837
Does this PR introduce a user-facing change?: