Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update plugin version in the readme #81

Merged
merged 3 commits into from
Dec 21, 2021
Merged

doc: update plugin version in the readme #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d82565
doc: update readme
humblec Dec 20, 2021
e93cbbc
Change the driver version to 0.1.0
humblec Dec 21, 2021
02c96a4
Update SECURITY_CONTACTS file
humblec Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,20 @@
## Usage:

### Start ISCSI driver

```
$ sudo ./bin/iscsiplugin --endpoint tcp://127.0.0.1:10000 --nodeid CSINode
```

#### Get plugin info

```
$ csc identity plugin-info --endpoint tcp://127.0.0.1:10000
"ISCSI" "0.1.0"
Copy link
Member

@andyzhangx andyzhangx Dec 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first alpha version should be 0.1.0 and then 1.0.0 should be GA version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyzhangx the driver version in the code is 1.0.0, https://github.com/kubernetes-csi/csi-driver-iscsi/blob/master/pkg/iscsi/driver.go#L44 , so this correction. Considering the plan is to release I think we have to confirm the release state and then correct accordingly. Looks like its good to release alpha first . If we are in agreement, I will change the driver version in the code then? wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use 0.1.0 for alpha first, thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyzhangx done. ptal . thanks

```

#### NodePublish a volume

```
$ export ISCSI_TARGET="iSCSI Target Server IP (Ex: 10.10.10.10)"
$ export IQN="Target IQN"
Expand All @@ -22,20 +25,23 @@ iscsitestvol
```

#### NodeUnpublish a volume

```
$ csc node unpublish --endpoint tcp://127.0.0.1:10000 --target-path /mnt/iscsi iscsitestvol
iscsitestvol
```

#### Get NodeID

```
$ csc node get-id --endpoint tcp://127.0.0.1:10000
CSINode
```

## Community, discussion, contribution, and support

Learn how to engage with the Kubernetes community on the [community page](http://kubernetes.io/community/).
Learn how to engage with the Kubernetes community on
the [community page](http://kubernetes.io/community/).

You can reach the maintainers of this project at:

Expand All @@ -44,7 +50,9 @@ You can reach the maintainers of this project at:

### Code of conduct

Participation in the Kubernetes community is governed by the [Kubernetes Code of Conduct](code-of-conduct.md).
Participation in the Kubernetes community is governed by
the [Kubernetes Code of Conduct](code-of-conduct.md).

[owners]: https://git.k8s.io/community/contributors/guide/owners.md

[Creative Commons 4.0]: https://git.k8s.io/website/LICENSE
1 change: 0 additions & 1 deletion SECURITY_CONTACTS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@
# DO NOT REPORT SECURITY VULNERABILITIES DIRECTLY TO THESE NAMES, FOLLOW THE
# INSTRUCTIONS AT https://kubernetes.io/security/

childsb
saad-ali
2 changes: 1 addition & 1 deletion pkg/iscsi/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const (
)

var (
version = "1.0.0"
version = "0.1.0"
)

func NewDriver(nodeID, endpoint string) *driver {
Expand Down