Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CVEs, add Make targets, update linters #91

Merged
merged 7 commits into from
Jan 25, 2022
Merged

Fix CVEs, add Make targets, update linters #91

merged 7 commits into from
Jan 25, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jan 25, 2022 •
edited
Loading

Signed-off-by: Humble Chirammal hchiramm@redhat.com

This PR covers below:

  • update of linters and a couple of linter additions
  • makefile target addition
  • update of dockerfile to fix CVE
  • release-tools update to master
NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2022
@humblec humblec force-pushed the e2e-1 branch 4 times, most recently from e721862 to d536ccc Compare January 25, 2022 10:20
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2022
@humblec humblec force-pushed the e2e-1 branch 3 times, most recently from 7326c69 to fdb3aab Compare January 25, 2022 10:49
@humblec humblec changed the title Updating linter and few targets added to makefile Fix CVEs, add Make targets, update linters Jan 25, 2022
@andyzhangx
Copy link
Member

@humblec follow this PR to fix the CVE: kubernetes-sigs/azurefile-csi-driver#895

@humblec
Copy link
Contributor Author

humblec commented Jan 25, 2022

@humblec follow this PR to fix the CVE: kubernetes-sigs/azurefile-csi-driver#895

Oh.. instead of updating basutils thought of updating the base image itself and if it goes through..

@humblec
Copy link
Contributor Author

humblec commented Jan 25, 2022

@humblec follow this PR to fix the CVE: kubernetes-sigs/azurefile-csi-driver#895

Oh.. instead of updating basutils thought of updating the base image itself and if it goes through..

@andyzhangx looks like not just base image helps , we need to update the package as well.. trying out.

@humblec humblec force-pushed the e2e-1 branch 4 times, most recently from d037e28 to a95074a Compare January 25, 2022 11:34
@humblec
update golangci-linter version to latest
2800a46 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Add clean and mod check targets to makefile
7753151 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
add codespell linter to the github workflow actions
a6e2356 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Squashed 'release-tools/' changes from 31aa44d..5d66471
1cb827b 
5d66471 Merge pull request kubernetes-csi#186 from humblec/sp
d066f1b Correct prow.sh typo and make codespell linter pass
762e22d Merge pull request kubernetes-csi#184 from pohly/image-publishing-troubleshooting
81e26c3 SIDECAR_RELEASE_PROCESS.md: add troubleshooting for image publishing

git-subtree-dir: release-tools
git-subtree-split: 5d664712ab7cbc626a7b0074291461ea57c3a25b
@humblec
Merge commit '1cb827b6742e759f8b4179b2279e80506e1c8d20' into HEAD
8a168c5
@humblec
Fix CVEs in plugin binary of iscsi driver
5b5f203 
Many CVEs are fixed in the latest base version and this lift the same.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec humblec force-pushed the e2e-1 branch 3 times, most recently from 6bbeb52 to 2b40cc9 Compare January 25, 2022 11:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2022
@humblec
Add shellcheck github action
1dca926 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Jan 25, 2022

@andyzhangx .. ptal.. this is a mix of few as mentioned in the PR description. 👍

andyzhangx
andyzhangx approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d2ac659 into kubernetes-csi:master Jan 25, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 25, 2022

Thanks @andyzhangx for the quick revert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@humblec @andyzhangx @k8s-ci-robot