-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support mountOptions in DeleteVolume #262
feat: support mountOptions in DeleteVolume #262
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 1647676395
💛 - Coveralls |
f0a8b79
to
ef41136
Compare
chore: provider secrets get permission add logging
ef41136
to
498e837
Compare
Is there a new docker image to use this patch? |
@huanghantao try with following command, helm repo add csi-driver-nfs https://raw.githubusercontent.com/kubernetes-csi/csi-driver-nfs/master/charts
helm repo update
helm install csi-driver-nfs csi-driver-nfs/csi-driver-nfs --namespace kube-system --version v3.1.0 --set image.nfs.pullPolicy=Always |
Thank you, I can delete the PVC normally now! |
I've had this problem recently, i am using csi driver for nfs, i can delete the pvc normally now too |
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: support mountOptions in DeleteVolume
since
DeleteVolumeRequest
does not haveVolumeCapabilities
field, this PR reads mountOptions from secret in DeleteVolume as a workaround.kubectl create secret generic mount-options --from-literal mountOptions="nfsvers=3"
csi.storage.k8s.io/provisioner-secret-name
andcsi.storage.k8s.io/provisioner-secret-namespace
setting:Which issue(s) this PR fixes:
Fixes #260
Special notes for your reviewer:
Does this PR introduce a user-facing change?: