-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inline volume support #266
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
618fdc5
to
22cf49d
Compare
Pull Request Test Coverage Report for Build 1682798475
💛 - Coveralls |
be5068e
to
16473fb
Compare
fix yaml refine tests fix example fix test
16473fb
to
6028557
Compare
Looks pretty good to me. Two possible tweaks:
|
fix test failure
010fbb4
to
e86dc68
Compare
@kfox1111 it's done, PTAL, thanks. added a new parameter as volumes:
- name: persistent-storage
csi:
driver: nfs.csi.k8s.io
volumeAttributes:
server: nfs-server.default.svc.cluster.local # required
share: / # required
mountOptions: "nfsvers=4.1,sec=sys" # optional |
Looks good to me. Thanks! :) |
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: add inline volume support
uesr could still set
--set feature.enableInlineVolume=false
to disable inline volume support in chart install.Which issue(s) this PR fixes:
Fixes #148
Special notes for your reviewer:
feat: add inline volume support
Does this PR introduce a user-facing change?: