Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts: fix master and control-plane nodeSelectors #603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

charts: fix master and control-plane nodeSelectors #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/latest/csi-driver-nfs/templates/csi-nfs-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ spec:
nodeSelector:
kubernetes.io/os: linux
{{- if .Values.controller.runOnMaster}}
node-role.kubernetes.io/master: ""
node-role.kubernetes.io/master: "true"
{{- end}}
{{- if .Values.controller.runOnControlPlane}}
node-role.kubernetes.io/control-plane: ""
node-role.kubernetes.io/control-plane: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whether all master node are labeled with node-role.kubernetes.io/control-plane: "", but as I know, the azure capz cluster are labeled as node-role.kubernetes.io/control-plane: ""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could set set --nodeSelector=xxx to make it work on your testing env if existing config does not work on your testing env.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, but it's a footgun. Also, as I remember, at least GKE also has "true" instead of "".

Would you be open to a patch that replaces these node selector with node affinities (which make it possible to declare an "Exists" relation instead of a strict match)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, check exists is better than strict match, thanks.

{{- end}}
{{- with .Values.controller.nodeSelector }}
{{ toYaml . | indent 8 }}
Expand Down