Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add baseRepo field in helm charts #637

Merged
merged 1 commit into from
Mar 26, 2024
Merged

feat: add baseRepo field in helm charts #637

merged 1 commit into from
Mar 26, 2024

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Mar 25, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add baseRepo field in helm charts
to address #635

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat: add baseRepo field in helm charts

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@andyzhangx andyzhangx mentioned this pull request Mar 25, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2024
@andyzhangx andyzhangx removed the request for review from mauriciopoppe March 25, 2024 13:29
@andyzhangx andyzhangx changed the title feat: add baseRepo filed in helm charts feat: add baseRepo field in helm charts Mar 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8421188814

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.915%
Totals Coverage Status
Change from base Build 8398573615: 0.0%
Covered Lines: 887
Relevant Lines: 1124
💛 - Coveralls

@andyzhangx andyzhangx merged commit 1f626a4 into kubernetes-csi:master Mar 26, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andyzhangx @k8s-ci-robot @coveralls