Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to csi-proxy v0.2.0 beta #106

Merged
merged 1 commit into from Sep 10, 2020
Merged

chore: upgrade to csi-proxy v0.2.0 beta #106

merged 1 commit into from Sep 10, 2020

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
chore: upgrade to csi-proxy v0.2.0 beta

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

TZ=UTC 
git --no-pager show \
  --quiet \
  --abbrev=12 \
  --date='format-local:%Y%m%d%H%M%S' \
  --format="%cd-%h"

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2020
@coveralls
Copy link

coveralls commented Sep 7, 2020 •
edited

Pull Request Test Coverage Report for Build 247262387

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.819%
Totals Coverage Status
Change from base Build 242296862: 0.0%
Covered Lines: 620
Relevant Lines: 706
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/assign @jingxu97

jingxu97
jingxu97 reviewed Sep 7, 2020
View reviewed changes
go.mod
@@ -236,7 +236,7 @@ replace (
github.com/kr/pretty => github.com/kr/pretty v0.1.0
github.com/kr/pty => github.com/kr/pty v1.1.5
github.com/kr/text => github.com/kr/text v0.1.0
github.com/kubernetes-csi/csi-proxy/client => github.com/kubernetes-csi/csi-proxy/client v0.0.0-20200330215040-9eff16441b2a
github.com/kubernetes-csi/csi-proxy/client => github.com/kubernetes-csi/csi-proxy/client v0.0.0-20200907051941-1c32ab57cb4f
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this replace is needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, while in this PR, there is no vendor code change since smb client is still alpha and remains the same.

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows

@andyzhangx andyzhangx closed this Sep 10, 2020
@andyzhangx andyzhangx reopened this Sep 10, 2020
@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows

2 similar comments
@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows

@jingxu97
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andyzhangx,jingxu97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ca5f7e2 into kubernetes-csi:master Sep 10, 2020
andyzhangx pushed a commit to andyzhangx/csi-driver-smb that referenced this pull request May 1, 2022
@k8s-ci-robot
Merge pull request kubernetes-csi#106 from msau42/fix-canary
a0f195c 
Only set staging registry when running canary job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 jingxu97 left review comments

@msau42 msau42 Awaiting requested review from msau42

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyzhangx @coveralls @jingxu97 @k8s-ci-robot