Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove 1903 1909 2004 Windows image which is end of life #391

Merged
merged 1 commit into from
Dec 11, 2021
Merged

cleanup: remove 1903 1909 2004 Windows image which is end of life #391

merged 1 commit into from
Dec 11, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
cleanup: remove 1903 1909 2004 Windows image which is end of life

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

cleanup: remove 1903 1909 2004 Windows image which is end of life

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1561649334

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.181%
Totals Coverage Status
Change from base Build 1561646782: 0.0%
Covered Lines: 817
Relevant Lines: 948
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/retest

3 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

@lizhuqi pull-csi-driver-smb-e2e-gce test is failing, would you take a look?

@andyzhangx
Copy link
Member Author

/retest

@lizhuqi
Copy link
Contributor

lizhuqi commented Dec 10, 2021

@lizhuqi pull-csi-driver-smb-e2e-gce test is failing, would you take a look?

Sure. I will take a look today.

@lizhuqi
Copy link
Contributor

lizhuqi commented Dec 10, 2021 •
edited

3 windows nodes failed to start because of the node set up failure

2021/12/10 11:34:49 GCEMetadataScripts: windows-startup-script-ps1: Exception caught in script:
2021/12/10 11:34:49 GCEMetadataScripts: windows-startup-script-ps1: At C:\k8s-node-setup.psm1:1308 char:5
2021/12/10 11:34:49 GCEMetadataScripts: windows-startup-script-ps1: + Throw ("Timeout while waiting ${timeout} seconds for kubelet and ...
2021/12/10 11:34:49 GCEMetadataScripts: windows-startup-script-ps1: + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021/12/10 11:34:49 GCEMetadataScripts: windows-startup-script-ps1: Kubernetes Windows node setup failed: Timeout while waiting 10 seconds for kubelet and kube-proxy

Log link:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-driver-smb/391/pull-csi-driver-smb-e2e-gce/1469266195453579264/artifacts/e2e-7e8e8014a3-6d836-windows-node-group-0ln1/serial-1.log

some errors in kubelet log:
I1210 11:34:41.019205 1468 server.go:796] "Failed to ApplyOOMScoreAdj" err="setting OOM scores is unsupported in this build"
E1210 11:34:41.019205 1468 server.go:301] "Failed to run kubelet" err="failed to run Kubelet: using dockershim is not supported, please consider using a full-fledged CRI implementation"

Log link:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_csi-driver-smb/391/pull-csi-driver-smb-e2e-gce/1469266195453579264/artifacts/e2e-7e8e8014a3-6d836-windows-node-group-0ln1/kubelet.log

I will update the test to switch to use containerd as removal of dockershim is scheduled for Kubernetes v1.24, see Dockershim Removal Kubernetes Enhancement Proposal.

@andyzhangx
Copy link
Member Author

/retest

3 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 9eb0ca2 into kubernetes-csi:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyzhangx @k8s-ci-robot @coveralls @lizhuqi