Build golangci-lint via go rather than curl | bash

[mattcary]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Remove use of curl'ing an arbitrary internet file through bash, which is now considered a security issue. Instead just use go build.

I created this by go mod download'ing the golangci, then go installing golangci-lint, which produced a lot of errors asking to go get certain dependencies. I did that by hand, go mod tidy'd, and everything seems to work.

Release note:

none

/assign @jingxu97
/assign @lizhuqi

[andyzhangx]

that's only for testing, is there still security issue here?

[mattcary]

Our vulnerability scanners don't distinguish for what the script is used for, only that it's in the repo. Even if it's in test it's still running in CI jobs etc.

[andyzhangx]

which vulnerability scanner are you referring?

[mattcary]

Internal google ones.

[andyzhangx]

that's hard way not using curl in testing sometimes, I think it's better exclude test folder if that's configurable?
actually this hack/verify-golint.sh could be deleted since there is already a github action doing same check:

csi-driver-smb/.github/workflows/static.yaml

Lines 12 to 16 in 40bce95

	- name: Run linter
	uses: golangci/golangci-lint-action@v2
	with:
	version: v1.29
	args: -E=gofmt,golint,misspell --timeout=30m0s

[mattcary]

Deleting this sounds even better to me! I'll update the PR.

[mattcary]

Had to update golang.org/x/text to v0.3.7

[mattcary]

/retest

[andyzhangx]

Had to update golang.org/x/text to v0.3.7

@mattcary could you approve this PR? #395

[mattcary]

Had to update golang.org/x/text to v0.3.7

@mattcary could you approve this PR? #395

done

[coveralls]

Pull Request Test Coverage Report for Build 1609514834

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 86.181%

---

Totals
Change from base Build 1609463185:	0.0%
Covered Lines:	817
Relevant Lines:	948

---

💛 - Coveralls

[andyzhangx]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment