Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subDir in storage class parameters #400

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jan 1, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add subDir in storage class parameters, e.g.

---
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: smb
provisioner: smb.csi.k8s.io
parameters:
  source: "//smb-server.default.svc.cluster.local/share"
  subDir: "existingSubDirectoryName"  # optional
  csi.storage.k8s.io/node-stage-secret-name: "smbcreds"
  csi.storage.k8s.io/node-stage-secret-namespace: "default"
volumeBindingMode: Immediate
mountOptions:
  - dir_mode=0777
  - file_mode=0777
  - uid=1001
  - gid=1001

Which issue(s) this PR fixes:

Fixes #398

Requirements:

Special notes for your reviewer:

Release note:

feat: add subDir in storage class parameters

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2022
@andyzhangx
Copy link
Member Author

this PR should solve the issue: #398
@ppenzo

@coveralls
Copy link

coveralls commented Jan 1, 2022

Pull Request Test Coverage Report for Build 1647759778

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 86.051%

Files with Coverage Reduction New Missed Lines %
pkg/smb/smb.go 3 92.73%
pkg/smb/controllerserver.go 15 87.04%
pkg/smb/nodeserver.go 27 83.28%
Totals Coverage Status
Change from base Build 1642373703: -0.1%
Covered Lines: 839
Relevant Lines: 975

💛 - Coveralls

@andyzhangx andyzhangx changed the title [WIP]feat: add subDir in storage class parameters feat: add subDir in storage class parameters Jan 1, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 1, 2022
@andyzhangx andyzhangx changed the title feat: add subDir in storage class parameters [WIP]feat: add subDir in storage class parameters Jan 1, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 1, 2022
@andyzhangx andyzhangx force-pushed the subdir branch 2 times, most recently from e8b5251 to a6a364e Compare January 2, 2022 03:26
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2022
@andyzhangx andyzhangx force-pushed the subdir branch 3 times, most recently from 1190d06 to 375d1e3 Compare January 2, 2022 08:41
@andyzhangx andyzhangx changed the title [WIP]feat: add subDir in storage class parameters feat: add subDir in storage class parameters Jan 2, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2022
fix test failure

fix failure

fix subdir

fix

correction

fix mount error

fix

fix windows test

refactor
@andyzhangx andyzhangx merged commit 4541a1a into kubernetes-csi:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Dynamic provisioning of PVs referring existing SMB shares of NAS filers
3 participants