Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create subdir if not exists #498

Merged

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jun 11, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: create subdir if not exists
In original behavior, subDir must exist if it's provided in storage class, this PR would create subdir if not exists

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: create subdir if not exists

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2022
@andyzhangx andyzhangx removed the request for review from jingxu97 June 11, 2022 11:43
@coveralls
Copy link

coveralls commented Jun 11, 2022

Pull Request Test Coverage Report for Build 2483674730

  • 46 of 48 (95.83%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 85.07%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/controllerserver.go 36 38 94.74%
Files with Coverage Reduction New Missed Lines %
pkg/smb/controllerserver.go 1 82.1%
Totals Coverage Status
Change from base Build 2439455779: 0.6%
Covered Lines: 792
Relevant Lines: 931

💛 - Coveralls

@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2022
@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-capz
/test pull-csi-driver-smb-e2e-capz-windows-2019

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-external-e2e

@andyzhangx
Copy link
Member Author

/retest

1 similar comment
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 12, 2022

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-csi-driver-smb-e2e-capz aa4b45b link false /test pull-csi-driver-smb-e2e-capz
pull-csi-driver-smb-e2e-capz-windows-2019 aa4b45b link false /test pull-csi-driver-smb-e2e-capz-windows-2019

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit 0e94a80 into kubernetes-csi:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants