feat: support pv/pvc metadata for subDir parameter

[andyzhangx]

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support pv/pvc metadata in subDir parameter

• subDir parameter supports following pv/pvc metadata transform

if subDir value contains following string, it would transforms into corresponding pv/pvc name or namespace

• ${pvc.metadata.name}
• ${pvc.metadata.namespace}
• ${pv.metadata.name}

Which issue(s) this PR fixes:

Fixes #502

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

feat: support pv/pvc metadata in subDir parameter

[coveralls]

Pull Request Test Coverage Report for Build 2522565494

• 22 of 25 (88.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.06%) to 85.131%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/smb/nodeserver.go	7	10	70.0%

Totals
Change from base Build 2516152007:	0.06%
Covered Lines:	813
Relevant Lines:	955

---

💛 - Coveralls

[jingxu97]

@andyzhangx does it require any csi provisioner side of changes to support this feature? Is this a feature that is currently supported by any driver?

[andyzhangx]

@andyzhangx does it require any csi provisioner side of changes to support this feature? Is this a feature that is currently supported by any driver?

@jingxu97 csi-provisioner already supports this by setting - "--extra-create-metadata=true", this is a feature specific to CSI driver , so answer is No, it depends on specific CSI driver.

I received such requirements from #502

[ayuzzz]

Hi there, we are eagerly waiting for the fix to be available. Do you have a timeline for this to be released?

We tried to install the master version of csi-smb driver and got the following sub-directory name (placeholders not getting replaced by actual parameters from PVC.yml).

[andyzhangx]

Hi there, we are eagerly waiting for the fix to be available. Do you have a timeline for this to be released?

We tried to install the master version of csi-smb driver and got the following sub-directory name (placeholders not getting replaced by actual parameters from PVC.yml).

@ayuzzz it's not merged, @jingxu97 could you approve? I think this is quite a useful feature.

[jingxu97]

is there e2e tests to validate the behavior including creation/deletion?

Could you also have an end to end example to show how this feature can be used?

[andyzhangx]

is there e2e tests to validate the behavior including creation/deletion?

Could you also have an end to end example to show how this feature can be used?

@jingxu97 Yes, such metadata is already added in e2e test (test/e2e/...):
"subDir": "subDirectory-${pvc.metadata.name}",

And example are already added to driver-parameters.md file, I think that's ok since it's special usage.

[jingxu97]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jingxu97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx,jingxu97]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

@jingxu97 there is quite similar implementation on nfs driver, could you also approve? kubernetes-csi/csi-driver-nfs#353 thanks.

[andyzhangx]

@ayuzzz pls try master branch with gcr.io/k8s-staging-sig-storage/smbplugin:canary image, let me know whether that works in your side, and then I would cut a new release.