Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add annotations in PV config to support Delete reclaimPolicy #572

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jan 12, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:
doc: add annotations in PV config to support Delete reclaimPolicy

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

  • this PR fixed following error:
# k describe pv pv-smb
Name:            pv-smb
Labels:          <none>
Annotations:     pv.kubernetes.io/bound-by-controller: yes
Finalizers:      [kubernetes.io/pv-protection]
StorageClass:    smb
Status:          Failed
Claim:           default/pvc-smb
Reclaim Policy:  Delete
Access Modes:    RWX
VolumeMode:      Filesystem
Capacity:        100Gi
Node Affinity:   <none>
Message:         error getting deleter volume plugin for volume "pv-smb": no deletable volume plugin matched
Source:
    Type:              CSI (a Container Storage Interface (CSI) volume source)
    Driver:            smb.csi.k8s.io
    FSType:
    VolumeHandle:      unique-volumeid
    ReadOnly:          false
    VolumeAttributes:      source=//smb-server.default.svc.cluster.local/share
Events:
  Type     Reason              Age   From                         Message
  ----     ------              ----  ----                         -------
  Warning  VolumeFailedDelete  22s   persistentvolume-controller  error getting deleter volume plugin for volume "pv-smb": no deletable volume plugin matched

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3903072730

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.845%

Totals Coverage Status
Change from base Build 3902929180: 0.0%
Covered Lines: 823
Relevant Lines: 970

💛 - Coveralls

@andyzhangx andyzhangx merged commit 41f7c32 into kubernetes-csi:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants