Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce mount lock to avoid volumeID collision issue #720

Merged
merged 1 commit into from Dec 27, 2023

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: reduce mount lock to avoid volumeID collision issue
the volumeHandle(volumeID) could be duplicated in PV, and duplicated volumeHandle(volumeID) is already allowed in latest k8s version, this PR reduces mount lock to avoid volumeID collision issue, the lock only happen when volumeID + stagingPath is the same

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: reduce mount lock to avoid volumeID collision issue

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 27, 2023
@andyzhangx andyzhangx merged commit d5dd4ac into kubernetes-csi:master Dec 27, 2023
20 of 21 checks passed
@tzifudzi
Copy link

tzifudzi commented Dec 27, 2023

Hi @andyzhangx,

I appreciate your contribution with this fix. That being said, could you please create an issue to reference regarding this error? Alternatively, could you provide some troubleshooting guidance for this fix and how to validate it?

I'm asking because I'm experiencing a problem that I think is related, but I'm not certain. Additional details about the initial issue and the steps leading to this fix would be greatly beneficial. For example, briefly describing how to know if this issue is affecting someone would be helpful.

@andyzhangx
Copy link
Member Author

Hi @andyzhangx,

I appreciate your contribution with this fix. That being said, could you please create an issue to reference regarding this error? Alternatively, could you provide some troubleshooting guidance for this fix and how to validate it?

I'm asking because I'm experiencing a problem that I think is related, but I'm not certain. Additional details about the initial issue and the steps leading to this fix would be greatly beneficial. For example, briefly describing how to know if this issue is affecting someone would be helpful.

@tzifudzi this PR fixed the error An operation with the given Volume ID ... already exists when you have multiple PVs with same volumeHandle value, and it won't fix the smb mount stuck issue which also leads to the above error. if you could make sure your PV has unique volumeHandle value, then this PR won't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants