Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanity: Disable ListVolumes pagination test #226

Merged
merged 1 commit into from Oct 14, 2019
Merged

sanity: Disable ListVolumes pagination test #226

merged 1 commit into from Oct 14, 2019

Conversation

avalluri
Copy link
Contributor

@avalluri avalluri commented Oct 10, 2019 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Volume created by testcase is not adding to cleanup list, hence it results in
volume leaking. This change fixes this issue.

The side effect of this testcase fix discovered a minor issue in mock driver implementation.
Which was hidden due to the leftover volume created by above testcase.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @avalluri. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2019
@pohly
Copy link
Contributor

pohly commented Oct 10, 2019

As discussed in intel/pmem-csi#424 (comment), the ListVolume pagination test is fragile. @avalluri showed there that it fails when the number of volumes is different. It probably also fails when csi-sanity isn't the only user of the cluster and other volumes are getting created or deleted concurrently.

I propose to disable the test in addition to fixing the volume leak. If someone has a good idea for improving the test, then they can do that later.

@msau42
Copy link
Collaborator

msau42 commented Oct 11, 2019

Yes, @davidz627 opened up #223 outlining various problems with the ListVolumes tests. I am ok with disabling the test because the issue in #223 I think is serious enough.

@msau42
Copy link
Collaborator

msau42 commented Oct 11, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2019
pohly
pohly requested changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avalluri please disable "pagination should detect volumes added between pages and accept tokens when the last volume from a page is deleted" by replacing It with XIt, with a comment that links to #223 and intel/pmem-csi#424 (comment).

mock/service/controller.go Outdated
@@ -73,7 +73,7 @@ func (s *service) CreateVolume(
case *csi.VolumeContentSource_Volume:
vid := req.GetVolumeContentSource().GetVolume().GetVolumeId()
// Check if the source volume exists.
if volID, _ := s.findVolNoLock("id", vid); volID > 0 {
if volID, _ := s.findVolNoLock("id", vid); volID >= 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change. Can you move it to a separate PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avalluri please disable "pagination should detect volumes added between pages and accept tokens when the last volume from a page is deleted" by replacing It with XIt, with a comment that links to #223 and intel/pmem-csi#424 (comment).

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change. Can you move it to a separate PR?

Done: #227

@pohly pohly mentioned this pull request Oct 11, 2019
Closed
@avalluri
sanity: fix and disable ListVolumes pagination testcase
46ef6af 
As discussed here: kubernetes-csi#226 (review)

This change fixes volume leakage in ListVolume pagination testcase and disable
this case till we improve the test.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2019
@avalluri avalluri changed the title sanity: fix volume leakage sanity: Disable ListVolumes pagination test Oct 11, 2019
@pohly
Copy link
Contributor

pohly commented Oct 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@avalluri avalluri mentioned this pull request Oct 14, 2019
Merged
@pohly
Copy link
Contributor

pohly commented Oct 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avalluri, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4e55894 into kubernetes-csi:master Oct 14, 2019
@pohly pohly mentioned this pull request Dec 9, 2019
Open
@alakae alakae mentioned this pull request Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly requested changes

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@pohly pohly

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avalluri @k8s-ci-robot @pohly @msau42