test suite reorganization #93

Within the test suite, each name is now unique. That simplifies debugging and when one test fails to remove its volume, the other tests are not affected. It also allows running tests in parallel. In addition, a random suffix gets added to also prevent collisions between different test runs. The random suffix gets reused for tests running inside the same process, but will be different for a single test run when running with "gingko -p". Related-to: kubernetes-csi#89.

Instead of testing individual functions of each service, the reorganized suite tests three services and for each service the functions that it provides. This allows removing code duplication in the common BeforeEach functions and enables further enhancements (common cleanup code, not duplicating the same test multiple times). While at it, the term "services" is now used consistently instead of "server", because that is what the CSI spec describes.

The full workflow test was done four times under different names. That's unnecessary and potentially confusing. Now it gets run once alongside the more specific function tests.

GetPublishInfo returns nil when called for a nil ControllerPublishVolumeResponse, therefore the if check is redundant. Always setting PublishInfo is another step towards inlining the parameter constructions.

By ensuring that we always have a valid CSISecrets, even if it only contains nil pointers, we can get rid of all the "if != nil" checks and the separate construction of the parameter structure.

There's no need to rename the csi spec, the package name already is "csi". Same for "gmock". The "context" module has been part of the Go standard library for quite a while now, we should use that directly.

Ginkgo invokes AfterEach in the order in which they are defined, therefore we should define the AfterEach where the connection is closed as late as possible. That way the tests can have their own AfterEach where they can still use the connection.

When a test fails, any volume operations that I may have done should be reversed. To achieve this, tests can register volumes for cleanup. To avoid unnecessary operations, volumes also get unregistered after a successful removal inside the test itself. Whether ControllerUnpublishVolume has to be called also gets tracked. For the sake of simplicity, NodeUnpublishVolume and (if supported) NodeUnstageVolume always get called. This is okay because they have to be idempotent and won't fail when called unnecessarily. testFullWorkflowSuccess gets inlined because that's easier than passing yet another parameter. Fixes: kubernetes-csi#89.

The tests previously defined only for Travis CI are now invoked with "make test". e2e.sh assumed that the binaries are in the regular search path. This is no longer necessary and in addition, mock is no longer placed in the developers $GOPATH/bin by the script.

"go fmt" always fixes code in place. As a result, running it again to report formatting errors doesn't do anything. The original intention probably was to check for errors and then report them. This is what is done now, using gofmt directly and it's diff output mode.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test suite reorganization #93

test suite reorganization #93

Commits on Jul 20, 2018