test: add unit tests

[fengzixu]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR added some unit tests for csi-handler and util package

Which issue(s) this PR fixes:

Fixes #11

Special notes for your reviewer:

Rely on: kubernetes-csi/csi-test#276

Does this PR introduce a user-facing change?:

None

[k8s-ci-robot]

Hi @fengzixu. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fengzixu]

/assign @fengzixu
/assign @xing-yang
/assign @NickrenREN

[NickrenREN]

@fengzixu thanks for doing this 👍

[NickrenREN]

/ok-to-test

[xing-yang]

@fengzixu CI failed with this error:
pkg/csi-handler/pv_checker_test.go:313:40: checker.csiControllerServer.EXPECT().ControllerGetVolume undefined (type *"github.com/kubernetes-csi/csi-test/v3/driver".MockControllerServerMockRecorder has no field or method ControllerGetVolume) pkg/csi-handler/pv_handler_test.go:193:27: controllerServer.EXPECT().ControllerGetVolume undefined (type *"github.com/kubernetes-csi/csi-test/v3/driver".MockControllerServerMockRecorder has no field or method ControllerGetVolume)

I think you need to use the latest csi-test which has ControllerGetVolume.

[fengzixu]

@fengzixu CI failed with this error:
pkg/csi-handler/pv_checker_test.go:313:40: checker.csiControllerServer.EXPECT().ControllerGetVolume undefined (type *"github.com/kubernetes-csi/csi-test/v3/driver".MockControllerServerMockRecorder has no field or method ControllerGetVolume) pkg/csi-handler/pv_handler_test.go:193:27: controllerServer.EXPECT().ControllerGetVolume undefined (type *"github.com/kubernetes-csi/csi-test/v3/driver".MockControllerServerMockRecorder has no field or method ControllerGetVolume)

I think you need to use the latest csi-test which has ControllerGetVolume.

@xing-yang Yep. Let me update me

[xing-yang]

Looks like CI still complained about ControllerGetVolume not defined.

[fengzixu]

@xing-yang test has passed

[fengzixu]

@xing-yang Hi Xing. All unit test cases have been added.

[xing-yang]

Can you squash your commits?

[xing-yang]

I just added a couple of more comments. Looks good other than that.

[xing-yang]

We are only checking volumes that are bound. If volumes are not bound, there should already be events generated by the existing controllers. Also the Message says "Volume not found" which does not match "Pending".
So change v1.VolumePending to v1.Bound

Rename "Test_AbnormalVolumeVolumePending" to "Test_AbnormalVolumeIOError". Change Message from "Volume not found" to "IO error".

[fengzixu]

Only test different error message looks like not necessary. Let me remove this test case

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fengzixu, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment