Prefix leader election lock name with "external-provisioner-leader"

[verult]

CSI has many controllers with leader election functionality. It's best to disambiguate between all the different locks used for LE with a provisioner-specific prefix.

However, a rolling upgrade to a version that includes the change will result in the possibility that two different locks are used at a given time, resulting in two leaders temporarily.

Should this be reconsidered when 2.0 rolls out?

[msau42]

We should make lock namespace configurable too.

[msau42]

We can make it an option to not break backwards compatibility.

/kind feature

[verult]

For a small bug like this I don't think adding a new flag option is justified. It could potentially make the provisioner a little harder to use, and exposing anything in the user interface carries some permanence.

I'm personally OK with leaving the fix until 2.0, and make sure every other CSI controller prefixes before moving to 1.0.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[verult]

/remove-lifecycle stale

[msau42]

/lifecycle frozen

[msau42]

/help

[k8s-ci-robot]

@msau42:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[msau42]

After some discussion we decided not to do this, with the consideration that we may want to combine all the sidecars in the future.
/close

[k8s-ci-robot]

@msau42: Closing this issue.

In response to this:

After some discussion we decided not to do this, with the consideration that we may want to combine all the sidecars in the future.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.