Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.29 - External Provisioner Change #952

Closed
sunnylovestiramisu opened this issue Jul 5, 2023 · 7 comments · Fixed by #1068
Closed

1.29 - External Provisioner Change #952

sunnylovestiramisu opened this issue Jul 5, 2023 · 7 comments · Fixed by #1068
Assignees

Comments

@sunnylovestiramisu
Copy link
Contributor

Tasks

  1. Feature gate for provisioner specific VolumeAttributesClass change
  2. Add support for provision PVC with a VolumeAttributesClass
@ConnorJC3
Copy link
Contributor

/assign @ConnorJC3

@sunnylovestiramisu
Copy link
Contributor Author

Is there a PR being submitted for review yet?

@ConnorJC3
Copy link
Contributor

@sunnylovestiramisu I was waiting for kubernetes/kubernetes#118863 to be merged first, but if you want I could create a PR based on that PR's version of the APIs.

@sunnylovestiramisu
Copy link
Contributor Author

@ConnorJC3 feel free to create a PR ahead and get an early review ahead of the schedule :)

@sunnylovestiramisu
Copy link
Contributor Author

FYI, the api change got separated and you can try to pull this change down locally in external-provisioner and make a change: https://github.com/kubernetes/kubernetes/pull/121104/files

@ConnorJC3
Copy link
Contributor

Hey, sorry about the slow response, I was sick for a few days. Thanks for splitting out the API change, I should be able to push my PR for review early next week.

@sunnylovestiramisu
Copy link
Contributor Author

/cc @msau42

@sunnylovestiramisu sunnylovestiramisu changed the title External Provisioner Change 1.29 - External Provisioner Change Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants