[KEP-3571] VolumeAttributesClass feature Demo

[carlory]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Just a demo and doesn't want to be merged.

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3751

Special notes for your reviewer:

Demo:

sudo ENABLE_ADMISSION_PLUGINS=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,Priority,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota,NodeRestriction,DefaultVolumeAttributesClass FEATURE_GATES=VolumeAttributesClass=true RUNTIME_CONFIG=api/all=true ./hack/local-up-cluster.sh

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3751-volume-attributes-class

[carlory]

/retest-required

[sunnylovestiramisu]

We can review this PR.

For others please hold off feature PRs for KEP-3751 until we can better coordinate the work.

[msau42]

/assign @sunnylovestiramisu

[carlory]

Initial API review, have not reviewed controller changes

Can you simplify the commits into the following:

• API changes
• auto generated api changes
• pv controller
• quota
• default admission controller

@msau42 @sunnylovestiramisu @xing-yang

This pr is used to do demo and get feedback from community. It's too large and hard to review and ensure the quality. So I will split it into several prs. Once the API changes is approved, we can work on the implementation together.

/hold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign deads2k, thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• api/OWNERS
• cmd/kube-controller-manager/OWNERS
• pkg/api/OWNERS
• pkg/apis/OWNERS
• pkg/controller/volume/OWNERS
• pkg/features/OWNERS
• pkg/generated/openapi/OWNERS
• pkg/kubeapiserver/OWNERS
• pkg/printers/OWNERS
• pkg/quota/v1/OWNERS
• pkg/registry/OWNERS
• pkg/volume/OWNERS
• staging/src/k8s.io/api/OWNERS
• staging/src/k8s.io/client-go/OWNERS
• test/integration/etcd/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@carlory: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-verify	4910c72	link	true	/test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sunnylovestiramisu]

I copied over the code to external-resizer but at build I am getting error:

../../vendor/k8s.io/client-go/listers/core/v1/volumeattributesclass.go:35:26: syntax error: unexpected VolumeAttributesClassLister in interface type; possibly missing semicolon or newline or }

But when I pulled down the change in the k/k repo this error does not show up.

[carlory]

@sunnylovestiramisu volumeattributesclass is in the storage.k8s.io/v1alpha1 package, not core/v1. I'm not sure why the error message is saying it's in core/v1.

BTW, the API pr is here.

[liggitt]

/remove-label api-review

since API review is happening in #121104

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[leilajal]

/triage accepted

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.