-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Node informer to prevent hitting the API server for all time #337
Use Node informer to prevent hitting the API server for all time #337
Conversation
Hi @mucahitkurt. Thanks for your PR. I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @verult |
/test pull-kubernetes-csi-external-provisioner-1-13-on-kubernetes-1-13 |
f974a21
to
186f2ce
Compare
186f2ce
to
d499439
Compare
d499439
to
7bebb32
Compare
… request Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
7bebb32
to
99a83ac
Compare
@verult PTAL |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, mucahitkurt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Use Node informer instead of hitting the API server for all Node resource request.
Which issue(s) this PR fixes:
Fixes #144
Special notes for your reviewer:
I used the commit from the PR: #327, I can also change that PR to add node informer.
Does this PR introduce a user-facing change?:
cc @msau42 @verult