Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node informer to prevent hitting the API server for all time #337

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

mucahitkurt
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Use Node informer instead of hitting the API server for all Node resource request.

Which issue(s) this PR fixes:
Fixes #144

Special notes for your reviewer:
I used the commit from the PR: #327, I can also change that PR to add node informer.

Does this PR introduce a user-facing change?:

NONE

cc @msau42 @verult

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mucahitkurt. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2019
@msau42
Copy link
Collaborator

msau42 commented Sep 6, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2019
@msau42
Copy link
Collaborator

msau42 commented Sep 6, 2019

/assign @verult

@msau42 msau42 added this to In progress in Topology: GA Sep 7, 2019
@mucahitkurt
Copy link
Contributor Author

/test pull-kubernetes-csi-external-provisioner-1-13-on-kubernetes-1-13
/test pull-kubernetes-csi-external-provisioner-unit

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2019
… request

Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
@mucahitkurt
Copy link
Contributor Author

@verult PTAL

@verult
Copy link
Contributor

verult commented Oct 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2019
@msau42
Copy link
Collaborator

msau42 commented Oct 28, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, mucahitkurt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 16a2da3 into kubernetes-csi:master Oct 28, 2019
Topology: GA automation moved this from In progress to Done Oct 28, 2019
@mucahitkurt mucahitkurt deleted the use-node-informer branch October 28, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Topology: GA
  
Done
Development

Successfully merging this pull request may close these issues.

Consider using Node & CSINodeInfo informers
4 participants