Update vendor dependencies #428

humblec · 2020-04-02T05:12:57Z

Update to client-go with ctx parameter

Kubernetes 1.18 introduced a ctx parameter in all API client-go API
calls. Whenever possible, that context is passed in by the caller
instead of making one up locally.

Newer releases of external-snapshotter and
sig-storage-lib-external-provisioner are needed because they have to
be compatible with the new client-go API (can't mix different versions
of it).

This PR handles:

kube dependencies are updated to v0.19.0-rc.2
sig-storage-lib-exernal-provisioner use v6 instead of v5.
external snapshotter dependency updated to v2.2.0-rc1

k8s-ci-robot · 2020-04-02T05:13:04Z

Hi @humblec. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

humblec · 2020-04-02T05:53:51Z

/release-note-none

msau42 · 2020-04-02T16:31:36Z

/ok-to-test

pohly

This is going to be more complicated. We first need a release of sig-storage-lib-external-provisioner and external-snapshotter which also use the new client-go API.

I can take over this work as I need it, too.

xing-yang · 2020-07-17T21:21:00Z

@pohly I see that sig-storage-lib-external-provisioner dep is already updated to 1.18. We also have a RC release for external-snapshotter whose dep is also updated to 1.18. So we can get this updated now?

xing-yang · 2020-07-21T01:53:36Z

Actually we need to bump the k8s to 1.19 to support vSphere CSI Migration. There's another PR submitted for that: #452.
@pohly I assume you also need CSIStorageCapacity changes in 1.19?
We should combine these two PRs.

@humblec are you available to update this PR to incorporate changes in #452?

xing-yang · 2020-07-21T02:02:50Z

Do we also need to bump sig-storage-lib-external-provisioner and external-snapshotter to 1.19?

humblec · 2020-07-21T16:36:36Z

Actually we need to bump the k8s to 1.19 to support vSphere CSI Migration. There's another PR submitted for that: #452.
@pohly I assume you also need CSIStorageCapacity changes in 1.19?
We should combine these two PRs.

@humblec are you available to update this PR to incorporate changes in #452?

sure!

Kubernetes 1.18 introduced a ctx parameter in all API client-go API calls. Whenever possible, that context is passed in by the caller instead of making one up locally. Newer releases of external-snapshotter and sig-storage-lib-external-provisioner are needed because they have to be compatible with the new client-go API (can't mix different versions of it).

humblec · 2020-07-23T12:45:15Z

Actually we need to bump the k8s to 1.19 to support vSphere CSI Migration. There's another PR submitted for that: #452.
@pohly I assume you also need CSIStorageCapacity changes in 1.19?
We should combine these two PRs.
@humblec are you available to update this PR to incorporate changes in #452?

sure!

The work was duplicated in other PR (#452) too which is pulled here after the discussion with @pohly

humblec · 2020-07-23T12:54:05Z

@xing-yang @msau42 @jsafrane ptal.

go.mod

xing-yang · 2020-07-23T12:56:43Z

pkg/controller/clone_controller.go

@@ -16,7 +18,7 @@ import (
 	"k8s.io/client-go/tools/cache"
 	"k8s.io/client-go/util/workqueue"
 	"k8s.io/klog"
-	"sigs.k8s.io/sig-storage-lib-external-provisioner/v5/controller"
+	"sigs.k8s.io/sig-storage-lib-external-provisioner/v6/controller"


Need to wait for the next release which depends on k8s 1.19

hmm.. bit confused.. we already have this import available in sig-s-l-e-provisioner with v6.0.0 release. https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/releases/tag/v6.0.0. So that should be enough ,Isnt it @xing-yang

k8s-ci-robot · 2020-07-23T13:11:00Z

@humblec: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-csi-external-provisioner-1-15-on-kubernetes-1-15	`16847b8`	link	`/test pull-kubernetes-csi-external-provisioner-1-15-on-kubernetes-1-15`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

xing-yang · 2020-07-23T19:28:35Z

The latest is v0.19.0-rc.2

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

humblec · 2020-07-24T09:49:36Z

The latest is v0.19.0-rc.2

sure, using it in the updated commit.

humblec · 2020-07-24T10:39:13Z

@xing-yang @msau42 @jsafrane ptal.

xing-yang

Need a sig-storage-lib-external-provisioner v7 or v7-rc1 release. Other than that, it looks good to me.

xing-yang · 2020-07-24T13:59:28Z

cmd/csi-provisioner/csi-provisioner.go

@@ -39,7 +38,7 @@ import (
 	utilflag "k8s.io/component-base/cli/flag"
 	csitrans "k8s.io/csi-translation-lib"
 	"k8s.io/klog"
-	"sigs.k8s.io/sig-storage-lib-external-provisioner/v5/controller"
+	"sigs.k8s.io/sig-storage-lib-external-provisioner/v6/controller"


Waiting for a v7 or v7-rc1

@xing-yang v7 update can be a separate PR too.

msau42 · 2020-07-29T01:49:25Z

/lgtm
/approve

k8s-ci-robot · 2020-07-29T01:49:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…go_modules/google.golang.org/grpc-1.54.0 Bump google.golang.org/grpc from 1.53.0 to 1.54.0

k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2020

k8s-ci-robot requested review from lpabon and saad-ali April 2, 2020 05:13

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 2, 2020

humblec force-pushed the dep-update branch 2 times, most recently from 93dd4bc to 3e22591 Compare April 2, 2020 05:53

humblec changed the title ~~Dep update~~ update vendor dependencies Apr 2, 2020

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2020

humblec changed the title ~~update vendor dependencies~~ [WIP] update vendor dependencies Apr 2, 2020

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2020

humblec force-pushed the dep-update branch from b3037e4 to 5161d4f Compare April 3, 2020 16:24

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2020

humblec force-pushed the dep-update branch from 12fafb9 to c6e981b Compare April 3, 2020 17:32

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2020

humblec force-pushed the dep-update branch from 16847b8 to c9ed9fe Compare June 19, 2020 10:20

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2020

pohly reviewed Jun 23, 2020

View reviewed changes

humblec force-pushed the dep-update branch from c9ed9fe to 710e040 Compare July 23, 2020 12:41

humblec changed the title ~~[WIP] update vendor dependencies~~ Update vendor dependencies Jul 23, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2020

xing-yang reviewed Jul 23, 2020

View reviewed changes

lift kube dependencies to v0.19.0-rc.2 build

64471b9

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

humblec mentioned this pull request Jul 24, 2020

Upgrade to v19 #456

Closed

xing-yang reviewed Jul 24, 2020

View reviewed changes

k8s-ci-robot assigned msau42 Jul 29, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020

k8s-ci-robot merged commit fbac058 into kubernetes-csi:master Jul 29, 2020

kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023

Merge pull request kubernetes-csi#428 from kubernetes-csi/dependabot/…

51defff

…go_modules/google.golang.org/grpc-1.54.0 Bump google.golang.org/grpc from 1.53.0 to 1.54.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update vendor dependencies #428

Update vendor dependencies #428

humblec commented Apr 2, 2020 •

edited

k8s-ci-robot commented Apr 2, 2020

humblec commented Apr 2, 2020

msau42 commented Apr 2, 2020

pohly left a comment

xing-yang commented Jul 17, 2020

xing-yang commented Jul 21, 2020

xing-yang commented Jul 21, 2020

humblec commented Jul 21, 2020

humblec commented Jul 23, 2020

humblec commented Jul 23, 2020

xing-yang Jul 23, 2020

humblec Jul 23, 2020

k8s-ci-robot commented Jul 23, 2020 •

edited

xing-yang commented Jul 23, 2020

humblec commented Jul 24, 2020

humblec commented Jul 24, 2020

xing-yang left a comment

xing-yang Jul 24, 2020

humblec Jul 24, 2020

msau42 commented Jul 29, 2020

k8s-ci-robot commented Jul 29, 2020

Update vendor dependencies #428

Update vendor dependencies #428

Conversation

humblec commented Apr 2, 2020 • edited

k8s-ci-robot commented Apr 2, 2020

humblec commented Apr 2, 2020

msau42 commented Apr 2, 2020

pohly left a comment

Choose a reason for hiding this comment

xing-yang commented Jul 17, 2020

xing-yang commented Jul 21, 2020

xing-yang commented Jul 21, 2020

humblec commented Jul 21, 2020

humblec commented Jul 23, 2020

humblec commented Jul 23, 2020

xing-yang Jul 23, 2020

Choose a reason for hiding this comment

humblec Jul 23, 2020

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 23, 2020 • edited

xing-yang commented Jul 23, 2020

humblec commented Jul 24, 2020

humblec commented Jul 24, 2020

xing-yang left a comment

Choose a reason for hiding this comment

xing-yang Jul 24, 2020

Choose a reason for hiding this comment

humblec Jul 24, 2020

Choose a reason for hiding this comment

msau42 commented Jul 29, 2020

k8s-ci-robot commented Jul 29, 2020

humblec commented Apr 2, 2020 •

edited

k8s-ci-robot commented Jul 23, 2020 •

edited