fix: changed the csistoragecapacity check namespace

[nbalacha]

The CSIStorageCapacity v1 check was attempting to create an invalid
object in the default namespace. This would fail if the pod did not
have permissions to the namespace. This will now use the namespace
specified in the NAMESPACE env variable.

Signed-off-by: N Balachandran nibalach@redhat.com

What type of PR is this?
/kind bug

What this PR does / why we need it:
The CSIStorageCapacity version check attempts to create an invalid resource in the default namespace. If the pod does not have permissions on "default" , this check returns with a fatal error.

Which issue(s) this PR fixes:
Fixes #752

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The CSIStorageCapacity version check will now use the namespace specified in the NAMESPACE env variable. This avoids a fatal unexpected error when checking for the V1 CSIStorageCapacity API error during startup.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: nbalacha (20a4836)

[k8s-ci-robot]

Welcome @nbalacha!

It looks like this is your first PR to kubernetes-csi/external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @nbalacha. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[humblec]

/ok-to-test

[humblec]

/assign @pohly

[pohly]

/lgtm

Before I approve and start preparing releases, was this tested on a cluster where the failure occurred?

[pohly]

Also, can the change note be extended with "This avoids a fatal unexpected error when checking for the V1 CSIStorageCapacity API error during startup.?

[nbalacha]

/lgtm

Before I approve and start preparing releases, was this tested on a cluster where the failure occurred?

Thanks. Yes, I tried it out on the same cluster where the original image failed.

[nbalacha]

Also, can the change note be extended with "This avoids a fatal unexpected error when checking for the V1 CSIStorageCapacity API error during startup.?

I've added this in the PR (sorry, didn't know what you meant by change note). Let me know if I need to change it elsewhere.

[pohly]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pohly]

I've added this in the PR (sorry, didn't know what you meant by change note).

Yes, that one.