Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizer may run without initializing #113

Closed
RaunakShah opened this issue Oct 7, 2020 · 4 comments
Closed

Resizer may run without initializing #113

RaunakShah opened this issue Oct 7, 2020 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@RaunakShah
Copy link
Contributor

resizeController.Run() waits for the informer caches to sync before spawning goroutines for syncPVCs - https://github.com/kubernetes-csi/external-resizer/blob/master/pkg/controller/controller.go#L250

If the cache syncing errors out, the error message is simply logged and resizer container never restarts.

root@422f45813bff2a241fdfeda9996a783b [ ~ ]# kubectl logs vsphere-csi-controller-5594766d5b-p6q2z -n kube-system -c csi-resizer -f
I1007 22:13:51.988959       1 main.go:79] Version : v1.0.0-rc2
I1007 22:13:51.995046       1 connection.go:153] Connecting to unix:///csi/csi.sock
I1007 22:13:52.000134       1 common.go:111] Probing CSI driver for readiness
I1007 22:13:52.013139       1 csi_resizer.go:77] CSI driver name: "csi.vsphere.vmware.com"
W1007 22:13:52.013753       1 metrics.go:142] metrics endpoint will not be started because `metrics-address` was not specified.
I1007 22:13:52.022003       1 controller.go:114] Register Pod informer for resizer csi.vsphere.vmware.com
I1007 22:13:52.026512       1 main.go:136] 1
I1007 22:13:52.027627       1 leaderelection.go:243] attempting to acquire leader lease  kube-system/external-resizer-csi-vsphere-vmware-com...
I1007 22:13:52.079012       1 leader_election.go:172] new leader detected, current leader: vsphere-csi-controller-5594766d5b-5vh99
I1007 22:14:11.410440       1 leaderelection.go:253] successfully acquired lease kube-system/external-resizer-csi-vsphere-vmware-com
I1007 22:14:11.410624       1 leader_election.go:172] new leader detected, current leader: vsphere-csi-controller-5594766d5b-p6q2z
I1007 22:14:11.411511       1 leader_election.go:165] became leader, starting
I1007 22:14:11.411683       1 controller.go:238] Starting external resizer csi.vsphere.vmware.com
I1007 22:14:11.612176       1 controller.go:248] Cannot sync pod, pv or pvc caches
I1007 22:14:11.612201       1 controller.go:253] Shutting down external resizer csi.vsphere.vmware.com
^C

root@422f45813bff2a241fdfeda9996a783b [ ~ ]# kubectl get pod -n kube-system
NAME                                      READY   STATUS    RESTARTS   AGE
vsphere-csi-controller-5594766d5b-p6q2z   6/6     Running   0          6m30s
xing-yang added a commit that referenced this issue Nov 19, 2020
c6a88c6 Merge pull request #113 from xing-yang/install_snapshot_controller
45ec4c6 Fix the install of snapshot CRDs and controller

git-subtree-dir: release-tools
git-subtree-split: c6a88c6ed96b939bd150472b12693252942116c7
jsafrane pushed a commit to jsafrane/external-resizer that referenced this issue Jan 4, 2021
…kerfile.openshift-baseimages-to-mach-ocp-build-data-config

Bug 1878163: Updating Dockerfile.openshift baseimages to mach ocp-build-data config
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 4, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants