-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to snapshot controller to add sourceVolumeMode #679
Changes to snapshot controller to add sourceVolumeMode #679
Conversation
/hold until #683 is merged |
1 similar comment
/hold until #683 is merged |
… mode conversion - Changes to snapshot controller to read the volume mode from the PV and add it to SourceVolumeMode field in VolumeSnapshotContent
f4fe826
to
5b578e8
Compare
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaunakShah, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you backport this to release-6.0? |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds changes to snapshot-controller to read the volume mode of the source PV and add it to the
Spec.SourceVolumeMode
field of the to-be-createdVolumeSnapshotContent
object.Also introduce a feature flag for this feature.
KEP - https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3141-prevent-volume-mode-conversion
Testing
v6.0.0-rc2
version ofcsi-snapshotter
andVolumeSnapshotContent
CRD. Setprevent-volume-mode-conversion
totrue
insnapshot-controller
.snapshot-controller
:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: