Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change storage version from v1beta1 to v1 #493

Merged
merged 1 commit into from Apr 23, 2021
Merged

Change storage version from v1beta1 to v1 #493

merged 1 commit into from Apr 23, 2021

Conversation

xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Apr 15, 2021 •
edited

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Change storage version from v1beta1 to v1 and add deprecation warnings.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Changes VolumeSnapshot API storage version from v1beta1 to v1; VolumeSnapshot v1beta1 is deprecated and will be removed in a future release.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 15, 2021
@xing-yang
Copy link
Collaborator Author

/test pull-kubernetes-csi-external-snapshotter-1-20-on-kubernetes-master

@xing-yang
Copy link
Collaborator Author

/test pull-kubernetes-csi-external-snapshotter-alpha-1-20-on-kubernetes-1-20

@xing-yang
Copy link
Collaborator Author

/assign @yuxiangqian

@xing-yang
Copy link
Collaborator Author

/retest

1 similar comment
@xing-yang
Copy link
Collaborator Author

/retest

@k8s-ci-robot
Copy link
Contributor

@xing-yang: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-snapshotter-1-20-on-kubernetes-master 9b4d302 link /test pull-kubernetes-csi-external-snapshotter-1-20-on-kubernetes-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuxiangqian
Copy link
Contributor

overall LGTM.
@xing-yang is conducting a testing to verify the desired behavior.

@xing-yang xing-yang changed the title WIP: Change storage version from v1beta1 to v1 Change storage version from v1beta1 to v1 Apr 21, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2021
@xing-yang
Copy link
Collaborator Author

@yuxiangqian I'm done with testing. Validation webhook works as expected.

In the latest PR, I also added deprecation messages. PTAL.

yuxiangqian
yuxiangqian reviewed Apr 23, 2021
View reviewed changes
Copy link
Contributor

@yuxiangqian yuxiangqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

client/config/crd/snapshot.storage.k8s.io_volumesnapshotclasses.yaml
@@ -72,6 +72,11 @@ spec:
name: Age
type: date
name: v1beta1
# This indicates the v1beta1 version of the custom resource is deprecated.
# API requests to this version receive a warning in the server response.
deprecated: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, this will not stop API server from serving, just matter of when users try to use the beta api, it will give a warning from API server, correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 679e71e into kubernetes-csi:master Apr 23, 2021
@Fedosin Fedosin mentioned this pull request Apr 27, 2021
Merged
This was referenced Sep 16, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxiangqian yuxiangqian yuxiangqian left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@yuxiangqian yuxiangqian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xing-yang @k8s-ci-robot @yuxiangqian