Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snapshots examples to start using v1 API #1501

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Update snapshots examples to start using v1 API #1501

merged 1 commit into from
Jun 9, 2021

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Apr 26, 2021 •
edited

What this PR does / why we need it:

Snapshots v1 API is GA from 1.20, so we can address it in our examples:
https://kubernetes.io/blog/2020/12/10/kubernetes-1.20-volume-snapshot-moves-to-ga/

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 26, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 26, 2021

/test cloud-provider-openstack-acceptance-test-csi-manila

@k8s-ci-robot
Copy link
Contributor

@Fedosin: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build failed.

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 27, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2021
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 27, 2021

We need to bump external-snapshotter first: kubernetes-csi/external-snapshotter#493

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 27, 2021

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 27, 2021

Build failed.

@Fedosin
Copy link
Contributor Author

Fedosin commented May 25, 2021

/test cloud-provider-openstack-acceptance-test-csi-manila

@k8s-ci-robot
Copy link
Contributor

@Fedosin: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 25, 2021

Build failed.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jun 4, 2021

/test cloud-provider-openstack-acceptance-test-csi-manila

@k8s-ci-robot
Copy link
Contributor

@Fedosin: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 4, 2021

Build failed.

@Fedosin Fedosin mentioned this pull request Jun 8, 2021
Closed
@Fedosin
Copy link
Contributor Author

Fedosin commented Jun 8, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021
@jichenjc
Copy link
Contributor

jichenjc commented Jun 8, 2021

the manila CI is not related
can you overwrite @lingxiankong ?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@gman0
Copy link
Member

gman0 commented Jun 8, 2021

/test cloud-provider-openstack-acceptance-test-csi-manila

@k8s-ci-robot
Copy link
Contributor

@gman0: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 8, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit fd0a34b into kubernetes:master Jun 9, 2021
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@Fedosin
Update snapshots examples to start using v1 API (kubernetes#1501)
8669d01 
Snapshots v1 API is GA from 1.20, so we can address it in
our examples:
https://kubernetes.io/blog/2020/12/10/kubernetes-1.20-volume-snapshot-moves-to-ga/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisky adisky Awaiting requested review from adisky

@dims dims Awaiting requested review from dims

Assignees

@lingxiankong lingxiankong

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fedosin @k8s-ci-robot @jichenjc @gman0 @lingxiankong