-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix certificate generation in webhook example #796
Conversation
After bb95725 the script was broken. This commit fixes this by respecting the format of TLS-type secrets in the script, too.
Hi @haslersn. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @deepakkinni |
This works. /approve |
@haslersn Can you add a release note? |
@xing-yang see my original post. The release note in bb95725 already encompasses this change. |
@haslersn Please add to the release note of this PR what bug is fixed here. You can add a reference to the other PR as well. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakkinni, haslersn, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After bb95725 the script was broken. This commit fixes this by respecting the format of TLS-type secrets in the script, too.
/kind bug
No release note needed as the breaking commit is not yet released.