Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent target kind to be an unsupported one #32

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Prevent target kind to be an unsupported one #32

merged 1 commit into from
Apr 1, 2020

Conversation

ialidzhikov
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
Prevent target kind to be an unsupported one

Which issue(s) this PR fixes:

Fixes #31

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

An issue causing cpva to fail starting when there are multiple API resources with duplicating names but different kinds is now fixed.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 30, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 30, 2020
@ialidzhikov
Copy link
Contributor Author

/assign @MrHohn @thockin

@ialidzhikov ialidzhikov requested a review from MrHohn April 1, 2020 06:56
@ialidzhikov
Prevent target kind to be an unsupported one
a0338cc 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov
Copy link
Contributor Author

ialidzhikov commented Apr 1, 2020 •
edited
Loading

@MrHohn, I enhanced the check so wrong groupVersions will be no longer added to the map.

@thockin thockin removed their assignment Apr 1, 2020
MrHohn
MrHohn approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit fc4eb85 into kubernetes-sigs:master Apr 1, 2020
@ialidzhikov ialidzhikov deleted the fix/target-kind branch April 2, 2020 08:29
@ialidzhikov
Copy link
Contributor Author

Thank you, @MrHohn!
Is it possible to have a new release (v0.8.2) that includes this fix as it is affecting our cpva deployments? Thanks in advance!

@MrHohn MrHohn mentioned this pull request Apr 2, 2020
Closed
@MrHohn
Copy link
Member

MrHohn commented Apr 2, 2020

@ialidzhikov Yep will do that later today. Filed #33 for that.

@cpretzer cpretzer mentioned this pull request Apr 3, 2020
Closed
@ialidzhikov ialidzhikov mentioned this pull request Apr 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@thockin thockin Awaiting requested review from thockin

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpva fails with "unknown target kind: Tap"
4 participants
@ialidzhikov @k8s-ci-robot @MrHohn @thockin