Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

WIP: bump k8s to 1.8.0-beta.1 #709

Closed
wants to merge 3 commits into from

Conversation

rphillips
Copy link
Contributor

@rphillips rphillips commented Sep 13, 2017

Issues:

  • modify cluster/manifests/kube-system-rbac-role-binding.yaml to use rbac.authorization.k8s.io/v1beta1 instead of v1alpha1
    • v1beta1 changes the selectors to be immutable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2017
@rphillips rphillips changed the title bump k8s to 1.8.0-beta.1 WIP: bump k8s to 1.8.0-beta.1 Sep 13, 2017
@squat
Copy link
Contributor

squat commented Sep 13, 2017

Awesome

@klausenbusk
Copy link
Contributor

The apiVersion of DaemonSet/Deployment should also be updated.

https://github.com/kubernetes/features/blob/master/release-1.8/release_notes_draft.md#major-themes

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2017
@@ -19,7 +19,7 @@ contexts:
user: kubelet
`)

var KubeSystemSARoleBindingTemplate = []byte(`apiVersion: rbac.authorization.k8s.io/v1alpha1
var KubeSystemSARoleBindingTemplate = []byte(`apiVersion: rbac.authorization.k8s.io/v1beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either works. v1alpha1 doesn't anymore due to kubernetes/kubernetes#51839

@ericchiang
Copy link
Contributor

ericchiang commented Sep 15, 2017

Seeing this error when trying to use this PR

Ignoring json-2.0.3 because its extensions are not built.  Try: gem pristine json --version 2.0.3
Ignoring nokogiri-1.6.8.1 because its extensions are not built.  Try: gem pristine nokogiri --version 1.6.8.1
Starting temporary bootstrap control plane...
Waiting for api-server...
Creating self-hosted assets...
	created          kube-apiserver secret
	created kube-controller-manager poddisruptionbudget
	created kube-controller-manager secret
	created kube-controller-manager deployment
	created                kube-dns deployment
	created                kube-dns service
	created        kube-flannel-cfg configmap
	created          kube-scheduler poddisruptionbudget
	created          kube-scheduler deployment
	created       system:default-sa clusterrolebinding
Error creating assets: [error when creating "/home/core/cluster/manifests/kube-apiserver.yaml": DaemonSet.apps "kube-apiserver" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"k8s-app":"kube-apiserver", "tier":"control-plane"}: `selector` does not match template `labels`, error when creating "/home/core/cluster/manifests/kube-flannel.yaml": DaemonSet.apps "kube-flannel" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"k8s-app":"flannel", "tier":"node"}: `selector` does not match template `labels`, error when creating "/home/core/cluster/manifests/kube-proxy.yaml": DaemonSet.apps "kube-proxy" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"k8s-app":"kube-proxy", "tier":"node"}: `selector` does not match template `labels`, error when creating "/home/core/cluster/manifests/pod-checkpointer.yaml": DaemonSet.apps "pod-checkpointer" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"tier":"control-plane", "k8s-app":"pod-checkpointer"}: `selector` does not match template `labels`]

NOTE: Bootkube failed to create some cluster assets. It is important that manifest errors are resolved and resubmitted to the apiserver.
For example, after resolving issues: kubectl create -f <failed-manifest>

	Pod Status: kube-controller-manager	Pending
	Pod Status:        pod-checkpointer	DoesNotExist
	Pod Status:          kube-apiserver	DoesNotExist
	Pod Status:          kube-scheduler	Pending

edit: removing the daemonsets commits fixed this.

@rphillips
Copy link
Contributor Author

Reproduced... It has something to do with defaulting labels now. Looking into it.

Reference

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2017
@rphillips
Copy link
Contributor Author

@ericchiang fixed... updated the selectors on the daemonsets.

@@ -1193,7 +1205,7 @@ data:
}
`)

var KubeCalicoTemplate = []byte(`apiVersion: extensions/v1beta1
Copy link
Contributor

@dghubble dghubble Sep 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look for CalicoNodeTemplate when you rebase, this was renamed on master

@coreosbot
Copy link

Can one of the admins verify this patch?

@ericchiang
Copy link
Contributor

@rphillips can we update this PR now that 1.8 is out? (cc @squat)

@squat
Copy link
Contributor

squat commented Sep 29, 2017

1.8.0 hyperkube is about to get cut. Waiting for the necessary LGTM and it will be available. xref coreos/kubernetes#167

@rphillips
Copy link
Contributor Author

yep.. then I'll tweak this PR to remove the API bumps, and do a migration of the APIs in a separate PR

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2017
@rphillips
Copy link
Contributor Author

closing in favor of #729

@rphillips rphillips closed this Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants