Disable rbac/v1alpha1, settings/v1alpha1, and scheduling/v1alpha1 by default

[jennybuckley]

What this PR does / why we need it: Disables alpha features which were previously enabled by default. Also changes tests which relied on these alpha features being enabled by default.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #47691

Special notes for your reviewer:

Release note:

Fixed a bug where some alpha features were enabled by default.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @jennybuckley. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jennybuckley]

/cc @caesarxuchao

[caesarxuchao]

Why is the import path changed?

[caesarxuchao]

In this PR, we'll need to make this test a feature test, by adding [Feature:PodPreset] in the test name, then the test won't run in pull-kubernetes-e2e-gce-etcd3.

In another PR, we need to add the test to the alpha suite, https://github.com/kubernetes/test-infra/blob/52b103fadb98e290d67fefeba6051eea8110fc46/jobs/config.json#L639.

cc @droot

[jennybuckley]

@caesarxuchao I think I have fixed the issue now, when you have time, could you look it over again?

Thanks

[krmayankk]

@jennybuckley with this change would enabling RBAC require feature flags for e.g. in 1.8 ?

[roycaihw]

cc @roycaihw

[jennybuckley]

Created kubernetes/test-infra#4392 to add the podpreset tests to the alpha suite

[jennybuckley]

@krmayankk yes, but only rbac/v1alpha1 will need that as rbac/v1beta1 and rbac/v1 are still enabled by default
rbac/v1alpha1 being enabled by default up until now is a bug (#47687)

[caesarxuchao]

lgtm. Could you squash?

@liggitt could you approve the change? It's addressing our previous discussion here. Thanks.

[jennybuckley]

@caesarxuchao squashed

[liggitt]

this just affects surfaced APIs, right, not the ability to decode in etcd?

/ok-to-test

[caesarxuchao]

Eh, the schduelingv1alpha1 is enabled by default. It's introduced in 1.8, so we can just remove it from the list. @jennybuckley could you remove this line as well?

cc @bsalamat the original author.

[jennybuckley]

Yes, I removed it as well as from the build file and the imports.
I was going to bring it up because I noticed that there was another alpha feature enabled by default, but I wasn't sure if that was intentional.

[jennybuckley]

/assign @sttts

[liggitt]

tagging owning sigs - @kubernetes/sig-auth-api-reviews @kubernetes/sig-scheduling-api-reviews @kubernetes/sig-apps-api-reviews

lgtm for sig-apps

We do not enable alpha APIs by default. rbac and podpresents were accidentally enabled by default in previous releases. We announced in 1.7 they would be disabled by default in 1.8 (and how to re-enable with --runtime-config). This should merge to complete that work and ensure we do not enable a new alpha API by default in 1.8

[liggitt]

a test like liggitt@746a119 would prevent alpha versions from getting re-added accidentally

[liggitt]

/retest

[bsalamat]

lgtm for disabling alpha scheduling APIs by default. It was not my intention to enable them by default.

[dims]

@jennybuckley @bsalamat : looks like this is stuck on a new test to be written. right?

[liggitt]

Can just pick liggitt@746a119 if you like

[jennybuckley]

@liggitt should I add this test to this PR, or in a separate one?

[liggitt]

I can open separately
/lgtm

[sttts]

/approve no-issue

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jennybuckley, liggitt, sttts

Associated issue: 47691

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/master/OWNERS [sttts]
• test/OWNERS [liggitt,sttts]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 51839, 51987)