This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
v0.12.x: feat: add CF stackNameOverride in cluster.yaml #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option in cluster.yaml to override the name of CF controlPlane, network and etcd stacks. This is useful for migration of CF stacks from kube-aws <0.11.x without creating a new VPC.
Because it is part of the cloudformation config in cluster.yaml.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
koen92
changed the title
Codecov Report
@@ Coverage Diff @@
## v0.12.x #1487 +/- ##
===========================================
- Coverage 37.91% 37.85% -0.06%
===========================================
Files 75 75
Lines 4595 4607 +12
===========================================
+ Hits 1742 1744 +2
- Misses 2611 2620 +9
- Partials 242 243 +1
Continue to review full report at Codecov.
|
mumoshu
approved these changes
Nov 9, 2018
koen92
added a commit
to koen92/kube-aws
that referenced
this pull request
Jan 9, 2019
kubernetes-retired#1487 introduced a bug when doing a partial stack upgrade with a stack name override. This is fixed by using the actual stack name in operation targets instead of the hard coded constants.
koen92
added a commit
to koen92/kube-aws
that referenced
this pull request
Jan 9, 2019
kubernetes-retired#1487 introduced a bug when doing a partial stack upgrade with a stack name override. This is fixed by using the actual stack name in operation targets instead of the hard coded constants.
koen92
added a commit
to koen92/kube-aws
that referenced
this pull request
Jan 11, 2019
kubernetes-retired#1487 introduced a bug when doing a partial stack upgrade with a stack name override. This is fixed by using the actual stack name in operation targets instead of the hard coded constants.
koen92
added a commit
to koen92/kube-aws
that referenced
this pull request
Jan 11, 2019
kubernetes-retired#1487 introduced a bug when doing a partial stack upgrade with a stack name override. This is fixed by using the actual stack name in operation targets instead of the hard coded constants.
mumoshu
pushed a commit
that referenced
this pull request
Jan 11, 2019
#1487 introduced a bug when doing a partial stack upgrade with a stack name override. This is fixed by using the actual stack name in operation targets instead of the hard coded constants.
koen92
added a commit
to koen92/kube-aws
that referenced
this pull request
Jan 14, 2019
kubernetes-retired#1487 introduced a bug when doing a partial stack upgrade with a stack name override. This is fixed by using the actual stack name in operation targets instead of the hard coded constants.
mumoshu
pushed a commit
that referenced
this pull request
Jan 18, 2019
#1487 introduced a bug when doing a partial stack upgrade with a stack name override. This is fixed by using the actual stack name in operation targets instead of the hard coded constants.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1484 for details/comments.