fix: Partial upgrades with stack name overrides

[koen92]

#1487 introduced a
bug when doing a partial stack upgrade with a stack name override.

This is fixed by using the actual stack names in operation targets
instead of the hard coded constants.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: c-knowles

If they are not already assigned, you can assign the PR to them by writing /assign @c-knowles in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[koen92]

Don't know if this TODO comment is still relevant?

[mumoshu]

Seems irrelevant now. Good catch!

[codecov-io]

Codecov Report

Merging #1524 into v0.12.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           v0.12.x    #1524   +/-   ##
========================================
  Coverage    37.86%   37.86%           
========================================
  Files           75       75           
  Lines         4608     4608           
========================================
  Hits          1745     1745           
  Misses        2620     2620           
  Partials       243      243

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a09fae4...cd14f27. Read the comment docs.

[koen92]

/assign @mumoshu

[mumoshu]

@koen92 Thanks for your effort! Just to clarify, what was the exact issue? You had to say e.g. apply --targets network even what you wanted was updating only the network stack named control-plane?

[koen92]

@mumoshu Thank you for your time!

When we try to do a partial validate and/or apply to only the Controlplane (or other target that has been renamed via the stackNameOverride option), we get the following error:

$ kube-aws-v0.12.0+dirty validate --targets control-plane
Validating UserData and stack template...
generating assets for control-plane
updating template url of control-plane
Error: failed to find assets for stack control-plane: [bug] failed to get the asset for the id "{control-plane stack.json}"

This happens because kube-aws checks for a hard coded Controlplane name (see https://github.com/kubernetes-incubator/kube-aws/blob/v0.12.x/core/root/operation_targets.go#L56 and https://github.com/kubernetes-incubator/kube-aws/blob/v0.12.x/core/root/operation_targets.go#L7 ).

With this PR I made this check dynamic and based on the actual Controlplane name (that is either 'control-plane' or the user provided name via cloudFormation.stackNameOverrides.controlPlane in cluster.yaml).

[mumoshu]

Ah, makes sense. And I think we have no other way to fix the issue. Good job 👍