This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Fix IamFleetRole syntax #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
======================================
Coverage 37.7% 37.7%
======================================
Files 51 51
Lines 3302 3302
======================================
Hits 1245 1245
Misses 1854 1854
Partials 203 203
Continue to review full report at Codecov.
|
|
@danielfm LGTM. Thanks a lot for your continuous support 👍 |
camilb
added a commit
to camilb/kube-aws
that referenced
this pull request
May 18, 2017
* kubernetes-incubator/master: RBAC setup improvements (kubernetes-retired#618) kube-dns improvements (kubernetes-retired#615) Fix dashboard version in labels and remove version from RC name (kubernetes-retired#625) Improve taints validation (kubernetes-retired#616) Fix IamFleetRole syntax (kubernetes-retired#619) Update default dashboard to 1.6.0 Replace custom 'minus' templating function with sprig-version and remove unused 'sha1' function Add sprig templating functions
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
* Fix formatting issue * Add regression test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #617.
Closes #186.