This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
Fix dashboard version in labels and remove version from RC name #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Btw @mumoshu is there any reason for version in RC name for dashboard? |
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
=======================================
Coverage 38.26% 38.26%
=======================================
Files 51 51
Lines 3316 3316
=======================================
Hits 1269 1269
Misses 1845 1845
Partials 202 202Continue to review full report at Codecov.
|
|
@Vrtak-CZ Nothing specific on my side - Even the corresponding kube-dashboard manifest in the upstream repo doesn't contain version numbers in its names. |
|
@mumoshu rebased and removed :-) |
|
@Vrtak-CZ LGTM. Thanks for your support 👍 |
mumoshu
changed the title
camilb
added a commit
to camilb/kube-aws
that referenced
this pull request
May 18, 2017
* kubernetes-incubator/master: RBAC setup improvements (kubernetes-retired#618) kube-dns improvements (kubernetes-retired#615) Fix dashboard version in labels and remove version from RC name (kubernetes-retired#625) Improve taints validation (kubernetes-retired#616) Fix IamFleetRole syntax (kubernetes-retired#619) Update default dashboard to 1.6.0 Replace custom 'minus' templating function with sprig-version and remove unused 'sha1' function Add sprig templating functions
kylehodgetts
pushed a commit
to HotelsDotCom/kube-aws
that referenced
this pull request
Mar 27, 2018
…rnetes-retired#625) * Fix dashboard version in labels * Remove version from dashboard RC name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.