This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
chore: make certain cert-manager properties configurable #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
mhrabovcin
reviewed
Nov 13, 2020
Signed-off-by: Hector Fernandez <hfernandez@mesosphere.com>
hectorj2f
force-pushed
the
hectorj2f/specify_properties_certificate
branch
from
de6512e
to
09fa192
Compare
mhrabovcin
approved these changes
Nov 13, 2020
armandgrillet
approved these changes
Nov 13, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: armandgrillet, hectorj2f, mhrabovcin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hector Fernandez hfernandez@mesosphere.com
What this PR does / why we need it:
While migrating from older cert-manager versions to the latest, we found that older cert-manager version set a default organization if the organization was empty. However the new cert-manager version ignores that default organization if it is not specified as part of the certificate fields. Therefore we should make these properties configurable for the ca generated certificate via cert-manager.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: