Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Refactor Jenkins tests and base them on automated client. #139

Merged
merged 2 commits into from
Dec 8, 2016

Conversation

kibbles-n-bytes
Copy link
Contributor

No description provided.

@arschles
Copy link
Contributor

arschles commented Dec 8, 2016

Can we put Jenkins related stuff into hack/jenkins from here on out?

@kibbles-n-bytes
Copy link
Contributor Author

Sorry guys, all the file locations and such are all over the place at the moment due to differing conventions, I'm on it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2016
@kibbles-n-bytes
Copy link
Contributor Author

kibbles-n-bytes commented Dec 8, 2016

Alright, things should be moved all into hack/ now. I didn't move stuff into hack/jenkins because the intent with these scripts is that they were created in order to be able to use them by Jenkins, but they should be general purpose and able to be used locally. They do rely on you deploying to a GCP project, however, but the intent was to later remove that coupling.

@arschles
Copy link
Contributor

arschles commented Dec 8, 2016

@mkibbe1993 thanks! I've created #143 for follow-up work to decide on the best location and do the moves.

I'd like to err on the side of expediency here (and in many other e2e-related PRs), as I believe that a solid foundation of e2e tests is important for us to have before we start making major functional changes to the codebase.

@arschles
Copy link
Contributor

arschles commented Dec 8, 2016

LGTM (LGTM2 label added)

@arschles arschles added LGTM2 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 8, 2016
@arschles
Copy link
Contributor

arschles commented Dec 8, 2016

needs rebase

@bmelville bmelville removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2016
@martinmaly
Copy link
Contributor

Are there any pending concerns with this PR that would prevent merging? If so, might we unblock the e2e testing work by opening issues for what remains and doesn't have issue already? Thanks, @arschles for opening #143!

@duglin
Copy link
Contributor

duglin commented Dec 8, 2016

LGTM

@duglin duglin merged commit 85b3fd8 into kubernetes-retired:master Dec 8, 2016
@kibbles-n-bytes kibbles-n-bytes deleted the refactor branch December 14, 2016 00:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants