This repository has been archived by the owner on May 6, 2022. It is now read-only.
Added searching and browsing use cases #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a few searching and browsing use cases to use-cases.md. Primarily, I want to make sure that we build an experience that can work in both CLI and UI environments.
arschles
reviewed
Oct 28, 2016
| 2. As a consumer, I'm able to see metadata about a service prior to | ||
| creation which allows me to see if this service fits my need. | ||
| 3. As a consumer, I'm able to see all the required and optional parameters | ||
| I'll need to pass to the service in order to create it. |
There was a problem hiding this comment.
Nit: The wording around "I'll need to pass" reads like you will need to pass optional parameters. Can you use this alternative version: "...all the required and optional parameters the service takes in order to create it"
arschles
reviewed
Oct 28, 2016
| * construction parameters | ||
| * name | ||
| * description | ||
| * default value |
There was a problem hiding this comment.
Based on the above item 3 under "Searching and Browsing Services", it seems like there should also be an "optional" parameter
duglin
approved these changes
Oct 31, 2016
| I'll need to pass to the service in order to create it. | ||
| 4. As a consumer, when listing services I see a union of the catalogs | ||
| from all brokers I have registered. However, if I want to restrict the | ||
| list to a specific broker I can pass that in as a flag. |
There was a problem hiding this comment.
I'm ok with call this out as a separate usecase, but it feels like a subset of the first one.
| * documentation/support urls | ||
| * icon URL | ||
| * image URLs - a list of images that could be displayed in a UI | ||
| * TOS link |
There was a problem hiding this comment.
I read that as 'terms of service'
There was a problem hiding this comment.
Ah, that would make sense. Let's just spell that out for those of us who aren't smart enough to know :-)
|
@kubernetes-incubator/maintainers-service-catalog PTAL, let's get this merged unless there are remaining reservations. |
|
One minor change request, and rebase needed. |
|
@westonh would you rebase this, and we'll get it merged? |
arschles
added
LGTM1
needs-rebase
|
@westonh what's the status of this PR? |
|
@westonh and i discussed someone else cherry-picking this commit in and
rebasing it. Go for it if you have time -- I probably won't get to it
until tomorrow.
…On Tue, Dec 6, 2016 at 12:53 PM, Aaron Schlesinger ***@***.*** > wrote:
@westonh <https://github.com/westonh> what's the status of this PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWXmMwdivz2QMffjnWYMaVjQclP-Didks5rFaEXgaJpZM4KgYZZ>
.
|
|
I'm closing this and will open a new PR with content rebased and nits addressed. |
jeffvance
pushed a commit
to jeffvance/service-catalog
that referenced
this pull request
Sep 5, 2017
provision bucket
jboyd01
pushed a commit
to jboyd01/service-catalog
that referenced
this pull request
Sep 6, 2018
…master V0.1.30 rebase master
piotrmiskiewicz
pushed a commit
to piotrmiskiewicz/service-catalog
that referenced
this pull request
Jun 3, 2019
piotrmiskiewicz
pushed a commit
to piotrmiskiewicz/service-catalog
that referenced
this pull request
Jun 12, 2019
k8s-ci-robot
pushed a commit
that referenced
this pull request
Sep 20, 2019
… (CRDs) solution (#2630) * Add basic validation to crds * Add webhook skeleton, remove api-server from chart, add webhoook server in chart, move PrepareForCreate login into webhook handler (#2) * Add webhook skeleton, remove api-server from chart, add webhoook server in chart, move PrepareForCreate login into webhook handler * Add logger and GVK matcher * Add test coverage for webhook (#6) * Add Status entry initialization in binding and instance controller (#5) * Change fs to label selector (#9) * Fix removing finalizer after switching to CRD /status sub-resource (#8) * Add tests to webhooks (#11) * Replace changevalidator with webhook (#14) * Replace default service plan with webhook (#10) * Add tests to webhooks - fix * Rewrite defaultServicePlan feature to webhook * Replace plugins by webhook (#16) * Replace ServiceBinding plugin by webhook * Replace Broker plugins by webhook * Adjust webhooks to multi validation handlers * Service Catalog going towards to CRDs (#18) * Migrate registry/strategy Updates to webhooks (#17) * Use Update instead of updateReference method (#19) * Replace tableconvertor with APC (#20) * Fix svcat tests after the rebase with the upstream master branch * Pre delete jobs - remove CRD after delete helm release (#21) * Apply fixes after executing `make verify` * Create docs about webhook implementation (#24) * Change the securePort for the webhook server because colidates with old api-server * Change import paths to kubernetes-sigs, and rebase with master * Apply fixes after rebase Fixes: * makefile targets, * instance deprovision operation * entries under additionalPrinterColumns in crds.yaml * unit tests after rebase * Update documentation (#40) * Update docs * Fix vendor after rebase with k8s 1.15 bump * Apply changes after review - remove the contrib/hack/crd folder - remove reference to Kyma project - rebase with current master - restore the image in chart - extract CRDs defintion to dedicated folder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few searching and browsing use cases to use-cases.md. Primarily, I want to make sure that we build an experience that can work in both CLI and UI environments.