-
Notifications
You must be signed in to change notification settings - Fork 388
Remove Secret listener from controller #2830
Remove Secret listener from controller #2830
Conversation
Hi @jasiu001. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Please remove RBAC for secret beside that 👍 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasiu001, mszostok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is a
What this PR does / why we need it:
This fix removes from controller "core sharedInformer" used for getting secret in the case when ServiceBroker or ClusterServiceBroker use authentication to connect with a broker.
SharedInformer shortly after start is synchronized, which causes huge memory usage when a lot of secret resources exist in the cluster (which is the norm at helm3 which keeps charts inside secrets).
The collection of resources can be performed directly by the Kubernetes client as it happens
controller_binding
during binding operation.Which issue(s) this PR fixes
Fixes #2824
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update