This repository has been archived by the owner on May 6, 2022. It is now read-only.
Remove remainder of controller HTTP surface #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
LGTM eventually I do think we'll need to pass in a struct to provide other options (like the interface to listen on), but for now port is ok. |
|
LGTM. Didn't notice that these were missed in #84 |
This (dead) code can now be removed since only /healthz HTTP handler is supported.
|
LGTM, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (dead) code can now be removed since only /healthz HTTP handler
is supported.
Also cleaning up propagation of port number from command line options.
There is no need to store the port number on the server instance.