Mark aggregated condition ready only when No error happened

kubernetes-sigs · Mar 6, 2020 · 179d1c0 · 179d1c0
1 parent a3b16d8
commit 179d1c0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/controllers/application_controller.go b/controllers/application_controller.go
@@ -96,7 +96,7 @@ func (r *ApplicationReconciler) getNewApplicationStatus(ctx context.Context, app
 		Objects: objectStatuses,
 	}
 	newApplicationStatus.ComponentsReady = fmt.Sprintf("%d/%d", countReady, len(objectStatuses))
-	if aggReady && errs != nil {
+	if aggReady && errs == nil {
 		setReadyCondition(newApplicationStatus, "ComponentsReady", "all components ready")
 	} else {
 		setNotReadyCondition(newApplicationStatus, "ComponentsNotReady", "some components not ready")