Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error #143

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix build error #143

merged 1 commit into from
Feb 6, 2020

Conversation

barney-s
Copy link
Contributor

@barney-s barney-s commented Feb 6, 2020

Build was failing with 'err' undefined.
Fix linting

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2020
@barney-s
Copy link
Contributor Author

barney-s commented Feb 6, 2020

@mortent @nan-yu

@mortent
Copy link
Member

mortent commented Feb 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2020
@barney-s
Copy link
Contributor Author

barney-s commented Feb 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@barney-s
Copy link
Contributor Author

barney-s commented Feb 6, 2020

/retest

@nan-yu
Copy link
Contributor

nan-yu commented Feb 6, 2020

@barney-s my PR was merged. You can rebase yours to retrigger the travis build

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2020
@barney-s
Copy link
Contributor Author

barney-s commented Feb 6, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@barney-s: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@barney-s
Copy link
Contributor Author

barney-s commented Feb 6, 2020

@mortent please LGTM again. re-ran the travis test.

@mortent
Copy link
Member

mortent commented Feb 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 97cb4c8 into kubernetes-sigs:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattfarina mattfarina Awaiting requested review from mattfarina

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@mortent mortent

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@barney-s @mortent @k8s-ci-robot @nan-yu