WIP: Support multiple certificates on annotations. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-build-var-at-build-time Fix build info injection [Small]
…e-docs-to-show-necessary-kube-ingress-annotation Add missing kube ingress.class annotation to examples [Small] kubernetes-sigs#369
When not empty the Host header check won't be enabled as part of the ALB listener routing rules. This commit closes kubernetes-sigs#371.
…nd-cidrs-annotation Add support for the inbound-cidrs annotation
This commit resolves kubernetes-sigs#371
Add ignore-host-header annotation
…eTimeout since time of 0 is invalid which is what is parsed from annotation
…-timeout Fix so if no connection-idle-timeout is set
…ller into alb-controller-refactor
…er-refactor Refactored alb-controller.go to enable more unit test coverage
…injection for unit testing
…er-refactor Refactored annotation/validation into interface
fix DescribeTargetGroupTargetsForArn with empty target list
Removed Josh Rosso from maintainers
…p-to-kubernetes-sigs Transfer ownership to kubernetes sigs
Add usage and values for the attributes annotation Credits to @masterzen who had added this to his PR but it had already been merged without this doc
Add license scan report and status
The ingress controller pod was getting in a crash loop specifically asking for waf-regional:GetWebACLForResource access. I searched the code and found references to the other permissions - specifically found them here: https://github.com/coreos/alb-ingress-controller/blob/master/pkg/aws/waf/waf.go
Update iam-policy.json - Provide WebACL permissions
Add ALB attributes annotation usage
…so fixing a bug which disassociated the web acl.
Fix a bug which disassociated Web ACLs right after associating them
…services were using the same port they would conflict. This wasn't a problem when services were nodeports only.
TargetGroup names are not unique enough in the current state
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
stafot
force-pushed
the
feature/support_multiple_certificates_annotations
branch
2 times, most recently
from
7bd5339
to
1ab3b83
Compare
k8s-ci-robot
added
size/M
stafot
force-pushed
the
feature/support_multiple_certificates_annotations
branch
2 times, most recently
from
543ab03
to
11c2b2b
Compare
k8s-ci-robot
added
size/S
stafot
force-pushed
the
feature/support_multiple_certificates_annotations
branch
2 times, most recently
from
e1b099b
to
dc3e777
Compare
stafot
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
stafot
force-pushed
the
feature/support_multiple_certificates_annotations
branch
from
dc3e777
to
2fed6e7
Compare
stafot
force-pushed
the
feature/support_multiple_certificates_annotations
branch
from
2fed6e7
to
dc25e2f
Compare
|
@stafot Please don't forget to update the ingress-resources.md docs with the new usage of the annotation |
|
@cv Thanks for your work. It looks that resolves the issue I tried to handle with this PR, so It looks that my WIP PR can be closed in favour of yours. Hope your PR will be merged soon so can test in my environment and provide you some more feedback. |
|
You can try it out by using `cvillela/alb-ingress-controller:latest` as the
docker image and tag, if that helps! ;)
…On Thu, 13 Sep 2018 at 03:39, Stavros Foteinopoulos < ***@***.***> wrote:
@cv <https://github.com/cv> Thanks for your work. It looks that resolves
the issue I tried to handle with this PR, so It looks that my WIP PR can be
closed in favour of yours. Hope your PR will be merged soon so can test in
my environment and provide you some more feedback.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#498 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAVRbACutgU7qkp5QC9xKZX8V_hUHX6ks5uaf2GgaJpZM4VlNjj>
.
|
|
@cv Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.