Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug which disassociated Web ACLs right after associating them #494

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Fix a bug which disassociated Web ACLs right after associating them #494

merged 1 commit into from
Jul 26, 2018

Conversation

bigkraig
Copy link

Resolves #490

@bigkraig
Changed waf naming to be clear that this is waf regional, not waf. Al…
1774390 
…so fixing a bug which disassociated the web acl.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 26, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 23.342% when pulling 1774390 on 490-fix into d9939a7 on master.

@bigkraig bigkraig merged commit 972b6c5 into master Jul 26, 2018
@bigkraig bigkraig deleted the 490-fix branch July 31, 2018 23:22
bigkraig added a commit that referenced this pull request Oct 1, 2018
@bigkraig
Merge pull request #494 from kubernetes-sigs/490-fix
e5430f6 
Fix a bug which disassociated Web ACLs right after associating them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bigkraig @coveralls @k8s-ci-robot