Add eks fargate antiaffinity to controller (same as is in node)

[wongma7]

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it? otherwise, the controller could get scheduled to a fargate node where it won't be able to function full y.

I'm going to hold off b umping the helm chart for now, trying to squeeze sidecar image updates in today as well

What testing is done?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@wongma7: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-aws-efs-csi-driver-e2e	2681ad2	link	/test pull-aws-efs-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[wongma7]

new one :

• Failure [1005.175 seconds]
[efs-csi] EFS CSI
/home/prow/go/src/github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e/e2e.go:211
[Driver: efs.csi.aws.com]
/home/prow/go/src/github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e/e2e.go:213
[Testpattern: Dynamic PV (default fs)] subPath
/home/prow/go/pkg/mod/k8s.io/kubernetes@v1.18.10/test/e2e/storage/testsuites/base.go:94
should support restarting containers using file as subpath [Slow][LinuxOnly] [It]
/home/prow/go/pkg/mod/k8s.io/kubernetes@v1.18.10/test/e2e/storage/testsuites/subpath.go:332
while cleaning up resource
Unexpected error:
<errors.aggregate | len:2, cap:2>: [
{
s: "pod "pod-subpath-test-dynamicpv-fqqb" was not deleted: timed out waiting for the condition",
},
[
{
error: {
cause: {
s: "PersistentVolume pvc-1c473248-8955-42ed-af4d-f4201349b8ab still exists within 5m0s",
},
msg: "Persistent Volume pvc-1c473248-8955-42ed-af4d-f4201349b8ab not deleted by dynamic provisioner",
},
stack: [0x18f4c4a, 0x191a687, 0x191c757, 0x902083, 0x901c9c, 0x901267, 0x907d8f, 0x907432, 0x90d6d1, 0x90d1e7, 0x90c9d7, 0x90efc6, 0x910e78, 0x910bcd, 0x192a4a9, 0x5234af, 0x474441],
},
],
]
[pod "pod-subpath-test-dynamicpv-fqqb" was not deleted: timed out waiting for the condition, Persistent Volume pvc-1c473248-8955-42ed-af4d-f4201349b8ab not deleted by dynamic provisioner: PersistentVolume pvc-1c473248-8955-42ed-af4d-f4201349b8ab still exists within 5m0s]
occurred
/home/prow/go/pkg/mod/k8s.io/kubernetes@v1.18.10/test/e2e/storage/testsuites/subpath.go:180

[aldojimenez]

I'm a little confused, does this mean that the installation of EFS CSI Helm chart is totally not supported on a Fargate only cluster? I'm attempting to install it but it's failing due to security context requiring priviledged field.

[wongma7]

@aldojimenez it's not supported. We have not tested it. I don't know if it will ever be supported, that is a question for EKS/fargate.

The controller will not run on fargate nodes because it requires metadata service.

The node will not run either, but EKS on fargate has their own solution for that: https://aws.amazon.com/blogs/containers/running-stateful-workloads-with-amazon-eks-on-aws-fargate-using-amazon-efs/

[k8s-ci-robot]

@wongma7: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.