Update ecr kustomize overlay to pull sidecars from private ecr, not public #549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? addresses #294 (comment).
What is this PR about? / Why do we need it? some users are in airgapped vpc and cannot pull from public ecr. Instead of having the ecr overlay be a mix of public and private, make it refer to private registry listed at https://docs.aws.amazon.com/eks/latest/userguide/add-ons-images.html.
What testing is done?