Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the iamidentitymappings CRD to support apiextensions.k8s.io/v1 #384

Closed
arruko opened this issue Jun 28, 2021 · 2 comments · Fixed by #397
Closed

Upgrade the iamidentitymappings CRD to support apiextensions.k8s.io/v1 #384

arruko opened this issue Jun 28, 2021 · 2 comments · Fixed by #397

Comments

@arruko
Copy link

arruko commented Jun 28, 2021

What happens?

The iamidentitymappings CRD was created with version apiextensions.k8s.io/v1beta1 of the api, which means that after version 1.22 of Kubernetes it can no longer be used.

Expecting to happen

Both kubernetes resources (including CRD) and aws-iam-authenticator source code supports version apiextensions.k8s.io/v1

The main problem is that after reviewing the code I see that the golang v1alpha1 kubernetes api package is widely used, so I would like to know what is your feedback on this change. If it doesn't affect anything other than the CRD I'd be happy to collaborate with a solution.

Logs

Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition

Versions of software

Toolchain Version:
Kubernetes: v1.22.0-beta.0

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2021
@rifelpet
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants