Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade usage of deprecated APIs removed in k8s 1.22 #11689

Closed
rifelpet opened this issue Jun 4, 2021 · 6 comments
Closed

Upgrade usage of deprecated APIs removed in k8s 1.22 #11689

rifelpet opened this issue Jun 4, 2021 · 6 comments
Labels
blocks-next kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@rifelpet
Copy link
Member

rifelpet commented Jun 4, 2021

/kind feature

1. Describe IN DETAIL the feature/behavior/change you would like to see.

https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-22

In order to support k8s 1.22, kops will need to update its usage of deprecated APIs that have been removed in k8s 1.22.

We first discovered this in testing the aws-load-balancer-controller.

Most of the changes would be in addon manifests, but dns-controller (Ingress v1beta1) and protokube (RBAC v1beta1) will need updates as well. There may be other areas of the code base that I missed in my quick scan.

A few challenges we'll run into:

  • Many of the replacement APIs were introduced in k8s versions newer than what is planned to be supported by kops 1.22. We'll have to decide whether to handle both API versions or narrow the support window for kops 1.22.
  • Many of the addon manifests come from upstream, so we should work with them to get their manifests updated, but we'll also need to decide what to do if their manifests and/or client code arent updated by the time we intend to release kops 1.22.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 4, 2021
@rifelpet rifelpet added this to the v1.22 milestone Jun 4, 2021
@johngmyers
Copy link
Member

We've added validation for those components which use APIs removed in k8s 1.22. When any of those update, we can remove the corresponding validation and cherry-pick to release-1.22.

Nothing else to track here.
/close

@k8s-ci-robot
Copy link
Contributor

@johngmyers: Closing this issue.

In response to this:

We've added validation for those components which use APIs removed in k8s 1.22. When any of those update, we can remove the corresponding validation and cherry-pick to release-1.22.

Nothing else to track here.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gtorre
Copy link

gtorre commented Jan 20, 2022

@johngmyers @rifelpet I believe aws load balancer controller has been updated, see kubernetes-sigs/aws-load-balancer-controller#2433

Are there plans to remove the validation? Is there a way to get around this if I'm currently using aws load balancer controller but want to upgrade to v1.22?

@olemarkus
Copy link
Member

We're still waiting for a release with that fix. should arrive in the near future. We'll remove the validation then.

@gtorre
Copy link

gtorre commented Jan 20, 2022

Thank you @olemarkus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks-next kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants